Skip to content

Hardening: Introduce overflow-checked custom allocation primitives#4649

Open
uwezkhan wants to merge 1 commit intofacebook:devfrom
uwezkhan:fix/alloc-integer-overflows
Open

Hardening: Introduce overflow-checked custom allocation primitives#4649
uwezkhan wants to merge 1 commit intofacebook:devfrom
uwezkhan:fix/alloc-integer-overflows

Conversation

@uwezkhan
Copy link
Copy Markdown

This PR introduces a safer allocation pattern across the library to prevent heap buffer overflows caused by integer overflows in nmemb * size calculations.

Infrastructure: Added ZSTD_customCalloc2 to allocations.h with robust SIZE_MAX overflow checks.
Remediation: Systematically refactored critical components (Thread Pool, MT-Compression, and Decompression DDict Hashsets) to use these safe primitives.
Critical Fix: Specifically addresses a potential 32-bit heap overflow in ZSTD_DDictHashSet_expand.
Verification: Added a unit test to validate the overflow protection logic.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 20, 2026

Hi @uwezkhan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Apr 20, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 20, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant