Conversation
Added SDWebImage dependency
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
@MobileConcepts updated the pull request - view changes |
|
@MobileConcepts updated the pull request - view changes |
MobileConcepts
left a comment
MobileConcepts
left a comment
There was a problem hiding this comment.
Removed a warning issue
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@MobileConcepts I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
2 participants
If using big images in push notifications, the loading screen might take quite a while until the user will see a notification. We prefer to show the user the text content immediately and let SDWebImage handle the lazy loading and caching.
The changes will check, if SDWebImage framework is available and will use it for handling Image Assets.