Skip to content
This repository was archived by the owner on Jan 1, 2025. It is now read-only.

Conversation

@alirezamirian
Copy link

react-dom is an optional peer dependency which means it should be listed in peerDependencies.

An example of an issue it can cause is this error when used with Module Federation:

No required version specified and unable to automatically determine one. Unable to find required version for "react-dom" in description file (/Users/be5806/workspace/wccj/channel-devkit-playground/channels/channel-default/node_modules/recoil/package.json). It need to be in dependencies, devDependencies or peerDependencies.

react-native should also be added but I didn't know what the version requirement is.

react-dom is an optional peer dependency which means it should be listed in peerDependencies.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants