Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] run_transformation and sign_control #1236

Merged
merged 8 commits into from
Mar 19, 2025
Merged

[fix] run_transformation and sign_control #1236

merged 8 commits into from
Mar 19, 2025

Conversation

alxlyj
Copy link
Contributor

@alxlyj alxlyj commented Mar 18, 2025 •
edited
Loading

Project Robyn

  • Fix all media call in run_transformations for proper media column handling.
  • Updated setup_sign_control to properly utilize paid_media_sign and prophet_vars.

Testing

  • Ran tutorial1.ipynb and tutorial1_src.ipynb.
image

@alxlyj alxlyj marked this pull request as ready for review March 18, 2025 20:58
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2025
@alxlyj alxlyj mentioned this pull request Mar 19, 2025
Merged
@alxlyj alxlyj requested a review from sumane81 March 19, 2025 00:47
sumane81
sumane81 approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@sumane81 sumane81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alxlyj alxlyj changed the title [fix] transformation [fix] run_transformation and sign_control Mar 19, 2025
@alxlyj alxlyj merged commit e20089b into main Mar 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumane81 sumane81 sumane81 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alxlyj @sumane81 @facebook-github-bot