Skip to content

Conversation

@MichalLauer
Copy link

Project Robyn

When I set small intervals on hyperparameters, the resulting hyperparameters.png plot does not show the density correctly.

I have a model with the following hyperparameters:

hyperparameters <- list(
  ...
  media_alphas = c(8, 9),
  media_gammas = c(0.001, 0.3),
  media_scales = c(0.0001, 0.001),  # <- Very narrow interval
  media_shapes = c(0.0001, 0.001),  # <- Very narrow interval
  ...
)

While the model fits correctly and does not show any issues, the resulting hyperparameters.png plot does not show any density for scale and shape for all parameters.

hypersampling

This PR updates the code so that

  1. the density is correctly shown for all parameters,
  2. the ordering is identical to previous versions, and
  3. there is no additional label on the right side of the plot (which is added after face_grid change)

The resulting chart looks like this:

hypersampling

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: API change with a documentation update
  • test: Additional test coverage
  • reformat: Code cleanup, recoding or reformating code

How Has This Been Tested?

  • Fork the repo and create your branch from master (latest dev version).
  • If you've changed docuemntation, run devtools::document(). Should update .Rd files.
  • Ensure all tests pass, run devtools::check(). Should have no notes, no warning, no errors.
  • Make sure your code lints.

@facebook-github-bot
Copy link

Hi @MichalLauer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants