Skip to content

Implement dynamic groups and new group request in relay - #112

Closed
afrind wants to merge 1 commit into
facebookexperimental:mainfrom
openmoq:new-group-request
Closed

Implement dynamic groups and new group request in relay#112
afrind wants to merge 1 commit into
facebookexperimental:mainfrom
openmoq:new-group-request

Conversation

@afrind

@afrind afrind commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Add support for DYNAMIC_GROUPS track extension and NEW_GROUP_REQUEST (NGR) parameter forwarding through the relay.

  • MoQForwarder tracks outstanding NGR and clears it when upstream largest group advances; exposes tryProcessNewGroupRequest() to consolidate the extract/gate/set/fire pattern used at all call sites
  • MoQRelay forwards NGR upstream via REQUEST_UPDATE when a downstream subscriber requests a new group on an existing upstream subscription; passes NGR through on new upstream subscribes without an extra update
  • Track status returns local forwarder state when an active subscription exists, falling back to upstream only when no subscription is found

Co-authored by: @akash-a-n

Add support for DYNAMIC_GROUPS track extension and NEW_GROUP_REQUEST
(NGR) parameter forwarding through the relay.

- MoQForwarder tracks outstanding NGR and clears it when upstream
  largest group advances; exposes tryProcessNewGroupRequest() to
  consolidate the extract/gate/set/fire pattern used at all call sites
- MoQRelay forwards NGR upstream via REQUEST_UPDATE when a downstream
  subscriber requests a new group on an existing upstream subscription;
  passes NGR through on new upstream subscribes without an extra update
- Track status returns local forwarder state when an active subscription
  exists, falling back to upstream only when no subscription is found

Co-Authored-By: Alan Frindell <8259689+afrind@users.noreply.github.com>
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 9, 2026
@meta-codesync

meta-codesync Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

@afrind has imported this pull request. If you are a Meta employee, you can view this in D95894248.

@meta-codesync

meta-codesync Bot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

@afrind merged this pull request in 0b901a8.

afrind pushed a commit to afrind/moxygen that referenced this pull request Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants