Add granular CMake targets with generate_cmake.py - #93
Closed
afrind wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
…al#93) Summary: Pull Request resolved: facebookexperimental#93 Add granular CMake target generation for moxygen, following the same pattern used for mvfst and proxygen. This creates individual library targets for each BUCK cpp_library, enabling more precise dependency tracking. Key changes: - Add MoxygenFunctions.cmake with moxygen_add_library() macro - Add generate_cmake.py to auto-generate CMakeLists.txt from BUCK files - Add lint_cmake_sync.py for arc lint integration - Update sample CMakeLists.txt files with correct granular dependencies - Fix GCC ICE in MoQChatClient.cpp by adding helper methods for aggregate init - Add BUILD_SAMPLES cmake option (default ON) - Require CMake 3.13+ for CMP0079 policy support Differential Revision: D91009068
afrind
force-pushed
the
export-D91009068
branch
from
February 15, 2026 17:51
566be7c to
cfd01f4
Compare
afrind
added a commit
to afrind/moxygen
that referenced
this pull request
Feb 15, 2026
…al#93) Summary: Pull Request resolved: facebookexperimental#93 Add granular CMake target generation for moxygen, following the same pattern used for mvfst and proxygen. This creates individual library targets for each BUCK cpp_library, enabling more precise dependency tracking. Key changes: - Add MoxygenFunctions.cmake with moxygen_add_library() macro - Add generate_cmake.py to auto-generate CMakeLists.txt from BUCK files - Add lint_cmake_sync.py for arc lint integration - Update sample CMakeLists.txt files with correct granular dependencies - Fix GCC ICE in MoQChatClient.cpp by adding helper methods for aggregate init - Add BUILD_SAMPLES cmake option (default ON) - Require CMake 3.13+ for CMP0079 policy support Differential Revision: D91009068
Contributor
|
This pull request has been merged in 1d4edfa. |
afrind
pushed a commit
to afrind/moxygen
that referenced
this pull request
Apr 18, 2026
…df02 sync: upstream moxygen ea8b533
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add granular CMake target generation for moxygen, following the same pattern
used for mvfst and proxygen. This creates individual library targets for each
BUCK cpp_library, enabling more precise dependency tracking.
Key changes:
Differential Revision: D91009068