Support Double Sided Material and fix image file close issue#226
Support Double Sided Material and fix image file close issue#226seanlinRL wants to merge 2 commits into
Conversation
The material has the "isDoubleSided" bool parameter. Because some models have double-sided texture settings, the new bool parameter is added to determine whether Gltf 'doubleSided' is enabled. The default value of this parameter is false.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
After file is opened, add fclose to avoid saving buffer data in memory
seanlinRL
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
I think this commit which can support double sided material and fix image file close issue. |
2 participants
The material has the "isDoubleSided" bool parameter. Because some models have double-sided texture settings, the new bool parameter is added to determine whether Gltf 'doubleSided' is enabled. The default value of this parameter is false.