Skip to content

Handle slashes in texture filenames#252

Open
griffin2000 wants to merge 2 commits into
facebookincubator:mainfrom
griffin2000:griffin2000/handleSlashes
Open

Handle slashes in texture filenames#252
griffin2000 wants to merge 2 commits into
facebookincubator:mainfrom
griffin2000:griffin2000/handleSlashes

Conversation

@griffin2000
Copy link
Copy Markdown

I noticed texture filenames with "non-native" slashes in the file name (e.g. a texture with \ in the folder path on mac) will cause the texture to fail to load. So in this PR I check for that case if the unaltered filename fails to load.

@facebook-github-bot
Copy link
Copy Markdown

Hi @griffin2000!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants