Add Stratified Randomization to MultiCellMarketSelection#143
Open
Th3Bust3r wants to merge 3 commits into
Open
Conversation
facebook-github-bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 'stratified' as an alternative sampling method. This stratifies the locations in rank_by_loc and then randomizes the cell assignment within each strata.
The current 'systematic' method only randomizes sample(1:k,k) once, and then repeats that sequence down the rank_by_loc. This produces identical groupings of markets in data_aux for MultiCellMarketSelection each time we run it, even though the cell number labels may differ. This is a potentially significant source of bias when running MultiCellMarketSelection for subsequent experiments with the same number of cells. By randomizing at each strata, we can ensure the market groupings in data_aux will be truly different by setting a different seed.