Added entityLocation and Chef.hs

Summary:
Mimicking a recent addition - anglelang.angle by adding the entityLocation predicate (its probably required to list symbols? as per Developing API page in Glean docs)

Chef.hs is required for Glass to synthesize a Symbol ID, which is required for proper functionality

Implemented Symbol (CodeChef.Entity, Chef.Symbol), and ToQName to enable go-to-def

Reviewed By: CatherineGasnier

Differential Revision: D78604841

fbshipit-source-id: cac08af2995ced745bb1555c8a080c511245cb51

Author: Amith Bhat Nekkare

glean/glass/Glean/Glass/SymbolId.hs

@@ -74,6 +74,7 @@ import Glean.Glass.SymbolId.Class
 import Glean.Glass.SymbolId.Angle ({- instances -})
 import Glean.Glass.SymbolId.Buck ({- instances -})
 import Glean.Glass.SymbolId.Cxx ({- instances -})
+import Glean.Glass.SymbolId.Chef ({- instances -})
 import Glean.Glass.SymbolId.Erlang ({- instances -})
 import Glean.Glass.SymbolId.Fbthrift ({- instances -})
 import Glean.Glass.SymbolId.Flow ({- instances -})
@@ -303,6 +304,7 @@ instance Symbol Code.Entity where
     Code.Entity_csharp x -> toSymbolWithPath x p
     Code.Entity_cxx x -> toSymbolWithPath x p
     Code.Entity_buck x -> toSymbolWithPath x p
+    Code.Entity_chef x -> toSymbolWithPath x p
     Code.Entity_erlang x -> toSymbolWithPath x p
     Code.Entity_graphql x -> toSymbolWithPath x p
     Code.Entity_hs x -> toSymbolWithPath x p
@@ -400,6 +402,7 @@ instance ToQName Code.Entity where
   toQName e = case e of
     Code.Entity_angle x -> toQName x
     Code.Entity_buck x -> toQName x
+    Code.Entity_chef x -> toQName x
     Code.Entity_csharp x -> toQName x
     Code.Entity_cxx x -> toQName x
     Code.Entity_erlang x -> toQName x

glean/glass/Glean/Glass/SymbolId/Chef.hs

@@ -0,0 +1,44 @@
+{-
+  Copyright (c) Meta Platforms, Inc. and affiliates.
+  All rights reserved.
+
+  This source code is licensed under the BSD-style license found in the
+  LICENSE file in the root directory of this source tree.
+-}
+
+{-# OPTIONS_GHC -Wno-orphans #-}
+
+module Glean.Glass.SymbolId.Chef (
+    {- instances and -}
+  ) where
+
+import qualified Glean
+import Glean.Glass.SymbolId.Class
+import Glean.Glass.Types (Name(..))
+import qualified Data.Text as T
+
+import qualified Glean.Schema.Chef.Types as Chef
+import Glean.Schema.CodeChef.Types as CodeChef
+    ( Entity(..) )
+
+
+instance Symbol CodeChef.Entity where
+  toSymbol e = case e of
+    CodeChef.Entity_symbol x -> toSymbolPredicate x
+    CodeChef.Entity_EMPTY -> return []
+
+instance Symbol Chef.Symbol_key where
+  toSymbol (Chef.Symbol_key identifier qualifiedName) = do
+    qNames <- mapM Glean.keyOf qualifiedName
+    name <- Glean.keyOf identifier
+    return $ qNames ++ [ name ]
+
+instance ToQName CodeChef.Entity where
+  toQName e = case e of
+    CodeChef.Entity_symbol definition -> do
+      Chef.Symbol_key identifier qNameList <- Glean.keyOf definition
+      qNameText <- mapM Glean.keyOf qNameList
+      let path = T.intercalate "::" qNameText
+      name <- Glean.keyOf identifier
+      return (Right (Name name, Name path))
+    CodeChef.Entity_EMPTY -> pure $ Left "ToQName: Unknown Chef entity"

glean/schema/source/code.chef.angle

@@ -6,6 +6,6 @@ schema code.chef.1 {
 
     type Entity =
     {
-        symbol : chef.Symbol
+        symbol : chef.Symbol |
     }
 }

glean/schema/source/codemarkup.angle

@@ -208,7 +208,9 @@ predicate EntityLocation:
     (codemarkup.graphql.GraphQLEntityLocation { E, Location };
      { graphql = E } = Entity) |
     (codemarkup.anglelang.AngleEntityLocation { E, Location };
-     { angle = E } = Entity);
+     { angle = E } = Entity) |
+    (codemarkup.chef.ChefEntityLocation { E, Location };
+     { chef = E } = Entity);
 
 # Maps a generated entity to its source definition
 predicate GeneratedEntityToIdlEntity:

glean/schema/source/codemarkup.chef.angle

@@ -6,7 +6,6 @@ import code.chef
 import codemarkup.types
 
 
-# Entity -> usage
 predicate ChefEntityUses:
   {
     target: code.chef.Entity,
@@ -16,6 +15,16 @@ predicate ChefEntityUses:
   {{ symbol = Symbol }, File, Span } where
   chef.ReferencedAt { Symbol, { File, Span } }
 
+
+predicate ChefEntityLocation:
+  {
+    entity: code.chef.Entity,
+    location: codemarkup.types.Location,
+  }
+  { { symbol = Symbol }, { EntityName, File, { span = Span }, nothing } } where
+    chef.DefinedAt { Symbol,{File, Span} };
+    Symbol.identifier = chef.Name EntityName;
+
 predicate ChefResolveLocation:
   {
     location: codemarkup.types.Location,
@@ -27,9 +36,9 @@ predicate ChefResolveLocation:
 
 predicate ChefFileEntityXRefLocations:
   {
-    file: src.File, # file where the reference is located
-    xref: codemarkup.types.XRefLocation, # XRefs from source to target declaration or definition
-    entity: code.chef.Entity, # actual entity that is being referenced
+    file: src.File,
+    xref: codemarkup.types.XRefLocation,
+    entity: code.chef.Entity,
   } { File, {Location, {span = Span}}, { symbol = Symbol } } where
   chef.ReferencedAt { Symbol, { File, Span } };
   Symbol.identifier = chef.Name EntityName;