[new-hs-indexer #3] Fix glass-democlient --service option #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fb-oss-glean canceled.
|
facebook-github-bot
added
the
CLA Signed
Contributor
|
@jjuliamolin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
simonmar
force-pushed
the
glass-democlient-fix
branch
from
c514baf to
0bb1d6f
Compare
Collaborator
Author
|
rebased |
CatherineGasnier
approved these changes
May 20, 2025
|
According to @jjuliamolin, this is covered by #511? |
Collaborator
Author
#511 is stacked on this one (i.e. it contains these changes too). What I imagined is that when you import them you get a stack of two diffs, then you land them in order. I don't know a better way to do stacked PRs, if there's another way that would work better for you do let me know. |
Avoids some cases where the Glean inferred type can diverge from the type expected at the call site.
It didn't work
simonmar
force-pushed
the
glass-democlient-fix
branch
from
0bb1d6f to
055260e
Compare
simonmar
changed the title
Contributor
|
@jjuliamolin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
They automatically merge into one if we import the later one first. Re-importing them now separately in right order :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't work
Note: stacked on #513