Amazon S3 backup support #615
Conversation
✅ Deploy Preview for fb-oss-glean ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
meta-cla
bot
added
the
CLA Signed
|
Plan: review internally with @parsonsmatt tomorrow then will mark as ready for review. |
lf-
force-pushed
the
jade/push-rxvyovyvttvl
branch
from
94b7e54 to
4fc007a
Compare
|
Reviewed with @parsonsmatt: we had some unsafePerformIO which existed to ensure that The goal here is that you can throw out the Backend object in client code and it won't really matter, and that AWS credentials are only discovered if the user is actually using the AWS features. It's now in a state I'm happy with, so please take a look! :) |
lf-
force-pushed
the
jade/push-rxvyovyvttvl
branch
from
4fc007a to
80d46de
Compare
simonmar
left a comment
simonmar
left a comment
There was a problem hiding this comment.
This looks great! Thanks for the contribution.
lf-
force-pushed
the
jade/push-rxvyovyvttvl
branch
4 times, most recently
from
1c05f2a to
f2e22ef
Compare
|
CI failure with 9.2.8 |
lf-
force-pushed
the
jade/push-rxvyovyvttvl
branch
from
f2e22ef to
79c5dfe
Compare
Fixed it :) Not surprised I got got by developing on the officially unsupported 9.10.x |
lf-
force-pushed
the
jade/push-rxvyovyvttvl
branch
3 times, most recently
from
62d547b to
7fa2a04
Compare
Uses amazonka-s3, which auto discovers credentials.
Did some manual testing:
```
glean --tier test --db-root ~/glean backup myrepo/0 s3:mybucket/jade-test
glean --tier test --db-root ~/glean2 restore s3:mybucket/jade-test/myrepo.0
```
Configuration ~/.config/glean/server/test, though I think this doesn't
actually matter?
```
{
"backup": {
"allowed": ["myrepo"],
"location": "s3:mybucket/jade-test"
},
"restore": {
"enabled": true
}
}
```
This feature really needs some documentation (especially given I don't
know if fb expected anyone external to immediately go and use it so it's
probably in a wiki somewhere?); I would appreciate the docs that exist
getting released, or I can maybe write some.
lf-
force-pushed
the
jade/push-rxvyovyvttvl
branch
from
7fa2a04 to
5da86a7
Compare
2 participants
Uses amazonka-s3, which auto discovers credentials.
Did some manual testing:
Configuration ~/.config/glean/server/test, though I think this doesn't actually matter?
This feature really needs some documentation (especially given I don't know if fb expected anyone external to immediately go and use it so it's probably in a wiki somewhere?); I would appreciate the docs that exist getting released, or I can maybe write some.