Support multiple output files #621
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fb-oss-glean canceled.
|
meta-cla
bot
added
the
CLA Signed
We had "groups" as a way to run a test multiple ways where the output files might differ, but that only works if you can run the test multiple ways without recompiling. For tests where the output depends on something in the environment, we need a way to manage multiple output files, so that's what this does. Additionally I've used it in the Haskell indexer tests, where the GHC version affects the output.
simonmar
force-pushed
the
test-multi-output
branch
from
bca1968 to
46d69c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had "groups" as a way to run a test multiple ways where the output files might differ, but that only works if you can run the test multiple ways without recompiling. For tests where the output depends on something in the environment, we need a way to manage multiple output files, so that's what this does.
Additionally I've used it in the Haskell indexer tests, where the GHC version affects the output.