Health check endpoint at /health #622
Open
+45
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fb-oss-glean canceled.
|
meta-cla
bot
added
the
CLA Signed
lf-
force-pushed
the
jade/push-vlmlnxsunkyz
branch
from
f625c4f to
0981c8f
Compare
Collaborator
|
Seems reasonable to me |
lf-
force-pushed
the
jade/push-vlmlnxsunkyz
branch
from
0981c8f to
ff7ca58
Compare
Problem: AWS ALB doesn't support health checking things except by status code (and nor does basically any other standard load balancer), and Glean only exports health checks as a Thrift service. Solution: turn health checks into HTTP status with a middleware. Requires: facebookincubator/hsthrift#167
lf-
force-pushed
the
jade/push-vlmlnxsunkyz
branch
from
ff7ca58 to
78c5230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: AWS ALB doesn't support health checking things except by status code (and nor does basically any other standard load balancer), and Glean only exports health checks as a Thrift service.
Solution: turn health checks into HTTP status with a middleware.
Requires: facebookincubator/hsthrift#167