bug fix, convert KB to Bytes - #637
Closed
jjuliamolin wants to merge 1 commit into
Closed
Conversation
Summary: Forgot to do a KB -> Bytes conversion, so disk limit was 1000x less than expected :) This is not in prod yet, the bug didn't affect prod and this fix won't either until we set this variable for glean.query.prod https://www.internalfb.com/code/configerator/[dc5e4b26185b5c8a2b17cb4f898e0872f7085882]/source/glean/server/glean.query.shadow.t3.cconf?lines=43-45 *note that the comment about 3.5TB is a bit leading, it's actually 4.2 TiB but our Shardmanager config is set to not use more than 85%* Reviewed By: malanka Differential Revision: D89123879
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@jjuliamolin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89123879. |
✅ Deploy Preview for fb-oss-glean canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Forgot to do a KB -> Bytes conversion, so disk limit was 1000x less than expected :) This is not in prod yet, the bug didn't affect prod and this fix won't either until we set this variable for glean.query.prod
https://www.internalfb.com/code/configerator/[dc5e4b26185b5c8a2b17cb4f898e0872f7085882]/source/glean/server/glean.query.shadow.t3.cconf?lines=43-45
note that the comment about 3.5TB is a bit leading, it's actually 4.2 TiB but our Shardmanager config is set to not use more than 85%
Reviewed By: malanka
Differential Revision: D89123879