Consolidate _ecce_pvalue_from_sigma_vectorized and ecce_pvalue_from_sigma (#240)#240
Open
Consolidate _ecce_pvalue_from_sigma_vectorized and ecce_pvalue_from_sigma (#240)#240
Conversation
TaXxER
requested review from
Lorenzo-Perini,
danielha1 and
flinder
as code owners
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 95.81% 95.87% +0.06%
==========================================
Files 9 9
Lines 1887 1892 +5
==========================================
+ Hits 1808 1814 +6
+ Misses 79 78 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meta-codesync
bot
force-pushed
the
export-D96753041
branch
from
4c08da6 to
1e4e257
Compare
meta-codesync
bot
changed the title
meta-codesync
bot
force-pushed
the
export-D96753041
branch
from
1e4e257 to
d1224a5
Compare
…igma (#240) Summary: Add `overload` type signatures to `_ecce_cdf` and `ecce_pvalue_from_sigma` to enable proper type narrowing: scalar input returns scalar, array input returns array. This resolves Pyre type errors at the three callsites (`ecce_pvalue`, `segments_ecce_pvalue`, `mce_pvalue`) by allowing Pyre to infer the correct return type based on the input type. Consolidate the vectorized implementation into the main functions, removing the separate `_ecce_pvalue_from_sigma_vectorized` helper. Differential Revision: D96753041
meta-codesync
bot
changed the title
meta-codesync
bot
force-pushed
the
export-D96753041
branch
from
d1224a5 to
d01c910
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add
overloadtype signatures to_ecce_cdfandecce_pvalue_from_sigmato enable proper type narrowing: scalar input returns scalar, array input returns array. This resolves Pyre type errors at the three callsites (ecce_pvalue,segments_ecce_pvalue,mce_pvalue) by allowing Pyre to infer the correct return type based on the input type. Consolidate the vectorized implementation into the main functions, removing the separate_ecce_pvalue_from_sigma_vectorizedhelper.Differential Revision: D96753041