feat(optimizer): Support DISTINCT aggregation on single set of arguments with order-by#1007
Open
kagamiori wants to merge 1 commit intofacebookincubator:mainfrom
Open
feat(optimizer): Support DISTINCT aggregation on single set of arguments with order-by#1007kagamiori wants to merge 1 commit intofacebookincubator:mainfrom
kagamiori wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
|
@kagamiori has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95008102. |
meta-cla
bot
added
the
CLA Signed
kagamiori
added a commit
to kagamiori/verax
that referenced
this pull request
Mar 5, 2026
…nts with order-by (facebookincubator#1007) Summary: Previously, axiom optimizer allows `agg(distinct ...)` aggregation calls when there is no `order by` in the aggregation call. This PR allows `agg(distinct ... order by ...)` when the order-by keys are a subset of distinct arguments. Differential Revision: D95008102
kagamiori
added a commit
to kagamiori/verax
that referenced
this pull request
Mar 5, 2026
…nts with order-by (facebookincubator#1007) Summary: Previously, axiom optimizer allows `agg(distinct ...)` aggregation calls when there is no `order by` in the aggregation call. This PR allows `agg(distinct ... order by ...)` when the order-by keys are a subset of distinct arguments. Differential Revision: D95008102
kagamiori
added a commit
to kagamiori/verax
that referenced
this pull request
Mar 6, 2026
…nts with order-by (facebookincubator#1007) Summary: Previously, axiom optimizer allows `agg(distinct ...)` aggregation calls when there is no `order by` in the aggregation call. This PR allows `agg(distinct ... order by ...)` when the order-by keys are a subset of distinct arguments. Distinct aggregations with order-by on columns not included in distinct arguments are not supported in the parallel execution mode (i.e., number of drivers * number of workers > 1). This follows the same behavior as Presto and DuckDB. Differential Revision: D95008102
kagamiori
added a commit
to kagamiori/verax
that referenced
this pull request
Mar 6, 2026
…nts with order-by (facebookincubator#1007) Summary: Pull Request resolved: facebookincubator#1007 Previously, axiom optimizer allows `agg(distinct ...)` aggregation calls when there is no `order by` in the aggregation call. This PR allows `agg(distinct ... order by ...)` when the order-by keys are a subset of distinct arguments. Distinct aggregations with order-by on columns not included in distinct arguments are not supported in the parallel execution mode (i.e., number of drivers * number of workers > 1). This follows the same behavior as Presto and DuckDB. Differential Revision: D95008102
kagamiori
added a commit
to kagamiori/verax
that referenced
this pull request
Mar 10, 2026
…nts with order-by (facebookincubator#1007) Summary: Previously, axiom optimizer allows `agg(distinct ...)` aggregation calls when there is no `order by` in the aggregation call. This PR allows `agg(distinct ... order by ...)` when the order-by keys are a subset of distinct arguments. Distinct aggregations with order-by on columns not included in distinct arguments are not supported in the parallel execution mode (i.e., number of drivers * number of workers > 1). This follows the same behavior as Presto and DuckDB. Differential Revision: D95008102
kagamiori
added a commit
to kagamiori/verax
that referenced
this pull request
Mar 10, 2026
…nts with order-by (facebookincubator#1007) Summary: Previously, axiom optimizer allows `agg(distinct ...)` aggregation calls when there is no `order by` in the aggregation call. This PR allows `agg(distinct ... order by ...)` when the order-by keys are a subset of distinct arguments. Distinct aggregations with order-by on columns not included in distinct arguments are not supported in the parallel execution mode (i.e., number of drivers * number of workers > 1). This follows the same behavior as Presto and DuckDB. Differential Revision: D95008102
kagamiori
added a commit
to kagamiori/verax
that referenced
this pull request
Mar 10, 2026
…nts with order-by (facebookincubator#1007) Summary: Pull Request resolved: facebookincubator#1007 Previously, axiom optimizer allows `agg(distinct ...)` aggregation calls when there is no `order by` in the aggregation call. This PR allows `agg(distinct ... order by ...)` when the order-by keys are a subset of distinct arguments. Distinct aggregations with order-by on columns not included in distinct arguments are not supported in the parallel execution mode (i.e., number of drivers * number of workers > 1). This follows the same behavior as Presto and DuckDB. Differential Revision: D95008102
…nts with order-by (facebookincubator#1007) Summary: Previously, axiom optimizer allows `agg(distinct ...)` aggregation calls when there is no `order by` in the aggregation call. This PR allows `agg(distinct ... order by ...)` when the order-by keys are a subset of distinct arguments. Distinct aggregations with order-by on columns not included in distinct arguments are not supported in the parallel execution mode (i.e., number of drivers * number of workers > 1). This follows the same behavior as Presto and DuckDB. Differential Revision: D95008102
kagamiori
force-pushed
the
export-D95008102
branch
from
f148d80 to
bba5be6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, axiom optimizer allows
agg(distinct ...)aggregation calls when there is noorder byin the aggregation call. This PR allowsagg(distinct ... order by ...)when theorder-by keys are a subset of distinct arguments.
Distinct aggregations with order-by on columns not included in distinct arguments are not
supported in the parallel execution mode (i.e., number of drivers * number of workers > 1).
This follows the same behavior as Presto and DuckDB.
Differential Revision: D95008102