feat(cli): Add query lifecycle callbacks to Console (#1057)#1057
Open
amitkdutta wants to merge 1 commit intofacebookincubator:mainfrom
Open
feat(cli): Add query lifecycle callbacks to Console (#1057)#1057amitkdutta wants to merge 1 commit intofacebookincubator:mainfrom
amitkdutta wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@amitkdutta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96492425. |
meta-codesync
bot
changed the title
amitkdutta
added a commit
to amitkdutta/axiom
that referenced
this pull request
Mar 14, 2026
…r#1057) Summary: Add optional start and completion callbacks to Console so callers can hook into the query lifecycle for logging, metrics, or other processing. - startCallback: invoked before parse for every query. - completionCallback: invoked after execution with query timing, row counts, and success/failure status. Differential Revision: D96492425
amitkdutta
force-pushed
the
export-D96492425
branch
from
6678f16 to
1a73fb6
Compare
mbasmanova
reviewed
Mar 14, 2026
axiom/cli/Console.h
Outdated
| std::string queryId; | ||
| std::string_view query; | ||
| bool succeeded{true}; | ||
| std::string errorMessage; |
Contributor
There was a problem hiding this comment.
Should this be an std::optional?
mbasmanova
reviewed
Mar 14, 2026
| std::string errorMessage; | ||
| /// Serialized query plan for downstream logging. | ||
| std::string planString; | ||
| uint64_t parseMicros{0}; |
Contributor
There was a problem hiding this comment.
Would you document all the fields?
I think we need timing for parsing, optimizing and execution. optimizeMicros is missing.
mbasmanova
reviewed
Mar 14, 2026
| uint64_t executionMicros{0}; | ||
| int64_t numOutputRows{0}; | ||
| std::chrono::system_clock::time_point createTime; | ||
| std::chrono::system_clock::time_point endTime; |
Contributor
There was a problem hiding this comment.
Let's change the order of fields to match QueryCompletionInfo.
- queryId
- query
- createTime
- endTime
- succeeded
- optional errorMessage
- parseMicros
- optimizeMicros
- executeMicros
- numOutputRows
- planString
Let's discuss whether we want a flat struct or perhaps group related fields into their own structs.
For example, I expect we'll want more execution stats beyond numOutputRows. Similarly, we may want more info about the plan shape. Maybe it doesn't make sense to duplicate QueryStartInfo fields, but rather add a field of type QueryStartInfo. Let's discuss.
amitkdutta
force-pushed
the
export-D96492425
branch
from
1a73fb6 to
574791f
Compare
amitkdutta
added a commit
to amitkdutta/axiom
that referenced
this pull request
Mar 17, 2026
…r#1057) Summary: Add optional start and completion callbacks to Console so callers can hook into the query lifecycle for logging, metrics, or other processing. - startCallback: invoked before parse for every query. - completionCallback: invoked after execution with query timing, row counts, and success/failure status. Reviewed By: hdikeman Differential Revision: D96492425
amitkdutta
force-pushed
the
export-D96492425
branch
from
574791f to
f7343db
Compare
amitkdutta
added a commit
to amitkdutta/axiom
that referenced
this pull request
Mar 17, 2026
…r#1057) Summary: Pull Request resolved: facebookincubator#1057 Add optional start and completion callbacks to Console so callers can hook into the query lifecycle for logging, metrics, or other processing. - startCallback: invoked before parse for every query. - completionCallback: invoked after execution with query timing, row counts, and success/failure status. Reviewed By: hdikeman Differential Revision: D96492425
amitkdutta
added a commit
to amitkdutta/axiom
that referenced
this pull request
Mar 17, 2026
…r#1057) Summary: Add optional start and completion callbacks to Console so callers can hook into the query lifecycle for logging, metrics, or other processing. - startCallback: invoked before parse for every query. - completionCallback: invoked after execution with query timing, row counts, and success/failure status. Reviewed By: hdikeman Differential Revision: D96492425
amitkdutta
force-pushed
the
export-D96492425
branch
from
f7343db to
2522857
Compare
…r#1057) Summary: Add optional start and completion callbacks to Console so callers can hook into the query lifecycle for logging, metrics, or other processing. - startCallback: invoked before parse for every query. - completionCallback: invoked after execution with query timing, row counts, and success/failure status. Reviewed By: hdikeman Differential Revision: D96492425
amitkdutta
force-pushed
the
export-D96492425
branch
from
2522857 to
ba9ab15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add optional start and completion callbacks to Console so callers can
hook into the query lifecycle for logging, metrics, or other processing.
counts, and success/failure status.
Reviewed By: hdikeman
Differential Revision: D96492425