feat: Add CatalogSchemaTableName and use it for table extraction (#1061)#1061
Open
hdikeman wants to merge 2 commits intofacebookincubator:mainfrom
Open
feat: Add CatalogSchemaTableName and use it for table extraction (#1061)#1061hdikeman wants to merge 2 commits intofacebookincubator:mainfrom
hdikeman wants to merge 2 commits intofacebookincubator:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
hdikeman
force-pushed
the
export-D96455374
branch
from
55f3af4 to
2d78852
Compare
hdikeman
added a commit
to hdikeman/verax
that referenced
this pull request
Mar 16, 2026
…okincubator#1061) Summary: Pull Request resolved: facebookincubator#1061 Axiom was recently moved to specifying table names using the SchemaTableName/CatalogSchemaTableName structures, but the referenced table extraction API was still returning raw strings. In this change, I am moving this API and the internal TableVisitor helper to the new structure Differential Revision: D96455374
meta-codesync
bot
changed the title
hdikeman
force-pushed
the
export-D96455374
branch
from
2d78852 to
f11b9b8
Compare
hdikeman
added a commit
to hdikeman/verax
that referenced
this pull request
Mar 16, 2026
…okincubator#1061) Summary: Pull Request resolved: facebookincubator#1061 Axiom was recently moved to specifying table names using the SchemaTableName/CatalogSchemaTableName structures, but the referenced table extraction API was still returning raw strings. In this change, I am moving this API and the internal TableVisitor helper to the new structure Differential Revision: D96455374
…acebookincubator#1060) Summary: Replace the `SchemaTableNameHash` functor with a `std::hash<SchemaTableName>` specialization so that `SchemaTableName` can be used directly as a key in standard and Folly hash containers without an explicit hash argument. Differential Revision: D96455393
…ebookincubator#1061) Summary: Add `CatalogSchemaTableName` in its own header/source files as a structured representation of fully-qualified table names (catalog + schema + table). Update `ViewMap`, `ReferencedTables`, and `TableVisitor` to use `CatalogSchemaTableName` instead of raw strings or `std::pair<std::string, SchemaTableName>`. Differential Revision: D96455374
meta-codesync
bot
changed the title
hdikeman
force-pushed
the
export-D96455374
branch
from
f11b9b8 to
aff6c47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add
CatalogSchemaTableNamein its own header/source files as a structured representation of fully-qualified table names (catalog + schema + table). UpdateViewMap,ReferencedTables, andTableVisitorto useCatalogSchemaTableNameinstead of raw strings orstd::pair<std::string, SchemaTableName>.Differential Revision: D96455374