fix(optimizer): Fix field resolution for nested aggregations across DT boundaries#1071
Open
peterenescu wants to merge 1 commit intofacebookincubator:mainfrom
Open
fix(optimizer): Fix field resolution for nested aggregations across DT boundaries#1071peterenescu wants to merge 1 commit intofacebookincubator:mainfrom
peterenescu wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
…T boundaries Summary: Adds a check to see if inner aliased aggregate functions have already been resolved, rather than attempting to re-resolve it in the outer query. This will prevent the optimizer from re-expanding the aliases *after* the aggregate no longer exists, resulting in "Field not found" errors. As an example: ```sql WITH t AS ( SELECT reduce(array_agg(ARRAY[v]), null, (s,x)->x, s->s) AS a FROM (VALUES (1)) t(v) ) SELECT sum(cardinality(a)) FROM t; ``` Differential Revision: D96821235
|
@peterenescu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96821235. |
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a check to see if inner aliased aggregate functions have already been resolved, rather than attempting to re-resolve it in the outer query. This will prevent the optimizer from re-expanding the aliases after the aggregate no longer exists, resulting in "Field not found" errors.
As an example:
Differential Revision: D96821235