feat(cli): Create SqlQueryRunner helpers on the fly #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncubator#796) Summary: The Connectors classes have useful logic to initialize connectors. To use SqlQueryRunner as a library, it will be helpful for users to have this class to instantiate their own SqlQueryRunner. The history code when registering a connector is not fully functional so we remove it in this diff. Differential Revision: D91146323
Summary: Remove PrestoParser, SchemaResolver, and VeloxHistory as instance variables and instead create as needed. This allows us to have each query have its own default schema (and even connector). Also allow caller to specify query maxWait in RunOptions Also change some VELOX_CHECKs to VELOX_USER_CHECKs when the issue is in user-supplied SQL statements. Differential Revision: D91166982
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove PrestoParser, SchemaResolver, and VeloxHistory as instance variables and
instead create as needed. This allows us to have each query have its own
default schema (and even connector). Also allow caller to specify query maxWait
in RunOptions
Also change some VELOX_CHECKs to VELOX_USER_CHECKs when the issue is in
user-supplied SQL statements.
Differential Revision: D91166982