procfs: Swallow InvalidFileFormat when parsing ns/pid, fixing invocation as unprivileged user - #8285
Conversation
Summary: When running below as an unprivileged user, reading /proc/1/ns/pid may yield an empty string due to permissions, resulting in an InvalidFileFormat error instead of an IoError. Fix below invocations as unprivileged user by ignoring InvalidFileFormat in read_all_pid_info_from_path (similar to EACCES) so that execution does not abort early when encountering an inaccessible process namespace.
|
Hi @Flowdalic! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
When running below as an unprivileged user, reading /proc/1/ns/pid may yield an empty string due to permissions, resulting in an InvalidFileFormat error instead of an IoError. Fix below invocations as unprivileged user by ignoring InvalidFileFormat in read_all_pid_info_from_path (similar to EACCES) so that execution does not abort early when encountering an inaccessible process namespace.