Skip to content

procfs: Swallow InvalidFileFormat when parsing ns/pid, fixing invocation as unprivileged user - #8285

Open
Flowdalic wants to merge 1 commit into
facebookincubator:mainfrom
Flowdalic:ignore-invalid-file-format-pidns
Open

procfs: Swallow InvalidFileFormat when parsing ns/pid, fixing invocation as unprivileged user#8285
Flowdalic wants to merge 1 commit into
facebookincubator:mainfrom
Flowdalic:ignore-invalid-file-format-pidns

Conversation

@Flowdalic

Copy link
Copy Markdown

Summary:

When running below as an unprivileged user, reading /proc/1/ns/pid may yield an empty string due to permissions, resulting in an InvalidFileFormat error instead of an IoError. Fix below invocations as unprivileged user by ignoring InvalidFileFormat in read_all_pid_info_from_path (similar to EACCES) so that execution does not abort early when encountering an inaccessible process namespace.

Summary:

When running below as an unprivileged user, reading /proc/1/ns/pid may
yield an empty string due to permissions, resulting in an
InvalidFileFormat error instead of an IoError. Fix below invocations as
unprivileged user by ignoring InvalidFileFormat in
read_all_pid_info_from_path (similar to EACCES) so that execution does
not abort early when encountering an inaccessible process namespace.
@meta-cla

meta-cla Bot commented Jul 20, 2026

Copy link
Copy Markdown

Hi @Flowdalic!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Jul 20, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant