Use if constexpr for a few PY_VERSION_HEX checks - #49
Closed
alexmalyshev wants to merge 1 commit into
Closed
Conversation
These don't need to be preprocessor directives.
meta-cla
Bot
added
the
CLA Signed
|
@alexmalyshev has imported this pull request. If you are a Meta employee, you can view this in D103723236. |
|
@alexmalyshev merged this pull request in d69f308. |
grantlouisherman
pushed a commit
to grantlouisherman/cinderx
that referenced
this pull request
May 5, 2026
) Summary: These don't need to be preprocessor directives. Pull Request resolved: facebookincubator#49 Reviewed By: yoney Differential Revision: D103723236 Pulled By: alexmalyshev fbshipit-source-id: f110138f1303b19dbc42486d78256e42105f9de1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These don't need to be preprocessor directives.