skip oss removed - #50
Closed
grantlouisherman wants to merge 11 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
grantlouisherman
marked this pull request as ready for review
May 5, 2026 14:58
grantlouisherman
force-pushed
the
skip_oss_jit
branch
from
May 5, 2026 15:24
64988de to
5191b4f
Compare
|
@grantlouisherman has imported this pull request. If you are a Meta employee, you can view this in D103862450. |
Summary: After all of the other diffs have landed this is just some cleanup to make things a little more understandable. Currently we're using cursors and doing a bunch of out of order code generation and things are kind of scattered around haphazardly. This gives us a "simple" generatePrologueBlocks which handles all of the prologue generation in the order it shows up in the final generated code. Reviewed By: alexmalyshev Differential Revision: D102081402 fbshipit-source-id: 863015605bc97dd11e5991249a0dddcb840b7b8b
Summary: This is now just a call + a yield value - it's straight forward to simplify now that 3.10 is gone. Reviewed By: mpage Differential Revision: D103313543 fbshipit-source-id: 9c187ad601d11c11db777b27b440aea8e443bd58
Summary: GCC will warn when its set for C code and it gets noisy. Pull Request resolved: facebookincubator#48 Reviewed By: yoney Differential Revision: D103699796 Pulled By: alexmalyshev fbshipit-source-id: ae2c1000eb05a3aeaf39124a1f084190669fa4c2
Summary: `s/getMultipiler/getMultiplier/g` Reviewed By: DinoV Differential Revision: D103731292 fbshipit-source-id: 8540ff335c38554de4d1e2d814691458ef29daae
Summary: Imported python/cpython `3.15.0a8+` from upstream rev [`7acee98`](https://www.github.com/python/cpython/commit/7acee984e8e2a88bcfb7a83e9c472902e340e5be) (committed 2026-05-04 21:38:07+00:00). # Commit Info Base: (`3.15.0a8+`) - [`1695221`](https://www.github.com/python/cpython/commit/16952218d0535904236e8a39851133688c9ce1f0) (commit date: 2026-04-30 02:39:29+00:00) Imported: (`3.15.0a8+`) - [`7acee98`](https://www.github.com/python/cpython/commit/7acee984e8e2a88bcfb7a83e9c472902e340e5be) (commit date: 2026-05-04 21:38:07+00:00) # Noteworthy file changes - Build system files (2 added): `PCbuild/python3tdll.vcxproj`, `PCbuild/python3tdll.vcxproj.filters` - C files (6 added, 1 removed): ``` + Include/cpython/sentinelobject.h + Include/internal/pycore_jit_unwind.h + Modules/_remote_debugging/gc_stats.c + Modules/_remote_debugging/gc_stats.h + Modules/_remote_debugging/interpreters.c + Python/jit_unwind.c - Include/sentinelobject.h ``` - Stdlib files (2 added, 1 removed) - Test files (9 added, 1 removed) - Low-signal files (64 added) (NEWS.d, docs, .github) - Other files (1 added) Complete list of added/removed files: https://www.internalfb.com/intern/everpaste/?color=0&handle=GJo5TCas_nigKWYHAJLDrq8mbdh9br0LAAAz Reviewed By: DinoV Differential Revision: D103748178 fbshipit-source-id: 08ee8832957bf14c6e8145d532667f5eaf9838c5
) Summary: These don't need to be preprocessor directives. Pull Request resolved: facebookincubator#49 Reviewed By: yoney Differential Revision: D103723236 Pulled By: alexmalyshev fbshipit-source-id: f110138f1303b19dbc42486d78256e42105f9de1
Summary: Add [cmake.defines] CMAKE_POSITION_INDEPENDENT_CODE=ON so that rebalancer's library archives are PIC. This is required because librebalancer.so is now built as a shared library; without PIC the final link fails with R_X86_64_PC32 / 'recompile with -fPIC' against its own intermediate object files. Reviewed By: uhebertj Differential Revision: D103767968 fbshipit-source-id: 05f290f6576fd843805b2dbeb8dd097a9f0de7e1
Summary: Putting it in its own function because it's complicated. This diff adds a `constexpr bool kFreeThreadedBuild` value for cases like the one in simplifySubscript() where we don't need conditional compilation between FT and non-FT. It also improves the case for unicode subscript with constant values on both sides in multithreaded compilation. Previously it would always early exit, now it'll fall through to the UnicodeSubscr case which will be a little bit faster. Reviewed By: yoney Differential Revision: D103345172 fbshipit-source-id: 6849f4482f038e19819d37b56df08081bab3ea42
Summary: We have a memory leak on ARM. When we have an inlined function we're using kBitTest but it sets different flags than x64 does. So we need an architecture specific check to see which flag to check. Reviewed By: mpage Differential Revision: D103768786 fbshipit-source-id: 702a5525b6780f4b5ae92ae4c2ed15d82a909016
Summary: Imported python/cpython `3.15.0a8+` from upstream rev [`5dd2161`](https://www.github.com/python/cpython/commit/5dd21617164cf69e848a70e3d7e32faf0bc3f279) (committed 2026-05-05 03:30:03+00:00). # Commit Info Base: (`3.15.0a8+`) - [`7acee98`](https://www.github.com/python/cpython/commit/7acee984e8e2a88bcfb7a83e9c472902e340e5be) (commit date: 2026-05-04 21:38:07+00:00) Imported: (`3.15.0a8+`) - [`5dd2161`](https://www.github.com/python/cpython/commit/5dd21617164cf69e848a70e3d7e32faf0bc3f279) (commit date: 2026-05-05 03:30:03+00:00) # Noteworthy file changes - Stdlib files (1 added) - Test files (3 removed) - Low-signal files (10 added) (NEWS.d, docs, .github) Complete list of added/removed files: https://www.internalfb.com/intern/everpaste/?color=0&handle=GGlp_h7ZdaLfBB0GAK_KiUQZRq0lbr0LAAAz Differential Revision: D103793452 fbshipit-source-id: 49e143ad692be104f37c23071443b45e6fe1ea14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address the removal of
skip_osswithin the cinderx codebase. Instead of doing everything at once I am going to remove in chunk this is the first iteration of this.