remove skip oss - #52
Closed
grantlouisherman wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
grantlouisherman
force-pushed
the
skip_oss_jit_
branch
from
May 5, 2026 17:55
6bfb4ce to
9357a41
Compare
grantlouisherman
marked this pull request as ready for review
May 5, 2026 18:29
|
@grantlouisherman has imported this pull request. If you are a Meta employee, you can view this in D103894475. |
grantlouisherman
force-pushed
the
skip_oss_jit_
branch
from
May 5, 2026 19:20
e3ef1b5 to
c83206a
Compare
grantlouisherman
marked this pull request as draft
May 5, 2026 19:32
grantlouisherman
force-pushed
the
skip_oss_jit_
branch
3 times, most recently
from
May 6, 2026 16:29
8b79dc6 to
a27c822
Compare
grantlouisherman
marked this pull request as ready for review
May 6, 2026 16:53
Contributor
Author
|
hey @alexmalyshev the reason why Im skipping test_corpus in OSS is because of a bug in NOT_TAKEN opcodes in 3.14. This was fixed in 3.15 and patched internally. I spoke to @DinoV about this this morning. |
alexmalyshev
reviewed
May 6, 2026
alexmalyshev
requested changes
May 6, 2026
grantlouisherman
force-pushed
the
skip_oss_jit_
branch
from
May 6, 2026 18:18
9c27390 to
d4131dc
Compare
Contributor
|
Comparing test results:
we are clearly running more tests. There's going to be formatting errors internally, but let's import and deal with them there. |
|
@grantlouisherman merged this pull request in 60f768e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing skip_oss function to enable this test in OSS builds