Skip to content

Schematized Monitor part1 - Create MetricInfo in MetricFrameBase - #467

Open
cmgrace wants to merge 1 commit into
mainfrom
export-D85995164
Open

Schematized Monitor part1 - Create MetricInfo in MetricFrameBase#467
cmgrace wants to merge 1 commit into
mainfrom
export-D85995164

Conversation

@cmgrace

@cmgrace cmgrace commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Summary:
create metricInfo class that contains the following information of metrics:

MetricInfo {
    metricName: cpu_time
    handler:
            TwTaskMetricHanlder.getCPUTime()
    validation:
            cpu_time >=0,
            cpu_time <= cpu_time_limit
    granularity: 
            second,
            minute
    aggregation: 
            p99, 
            p90    
    inclusion:
            LST/LSST
            / cpu_architacture(e.g. COOPER LAKE)
            / cpu_model(e.g. AMD)
            / kernel_version
    exclusion:
            (same as inclusion)
    criticality:
            high/low
} 

*criticality: if high criticality, means when data is missing to a certain level,
it should trigger a sev

the goal is to optimize data consumability workflow as:
{F1983199684}

Differential Revision: D85995164

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2025
@meta-codesync

meta-codesync Bot commented Nov 3, 2025

Copy link
Copy Markdown

@cmgrace has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85995164.

facebook-github-bot pushed a commit that referenced this pull request Nov 3, 2025
Summary:

create metricInfo class that contains the following information of metrics:
```
MetricInfo {
    metricName: cpu_time
    handler:
            TwTaskMetricHanlder.getCPUTime()
    validation:
            cpu_time >=0,
            cpu_time <= cpu_time_limit
    granularity: 
            second,
            minute
    aggregation: 
            p99, 
            p90    
    inclusion:
            LST/LSST
            / cpu_architacture(e.g. COOPER LAKE)
            / cpu_model(e.g. AMD)
            / kernel_version
    exclusion:
            (same as inclusion)
    criticality:
            high/low
} 

*criticality: if high criticality, means when data is missing to a certain level,
it should trigger a sev
```
the goal is to optimize data consumability workflow as:
 {F1983199684}

Differential Revision: D85995164
facebook-github-bot pushed a commit that referenced this pull request Nov 3, 2025
Summary:

create metricInfo class that contains the following information of metrics:
```
MetricInfo {
    metricName: cpu_time
    handler:
            TwTaskMetricHanlder.getCPUTime()
    validation:
            cpu_time >=0,
            cpu_time <= cpu_time_limit
    granularity: 
            second,
            minute
    aggregation: 
            p99, 
            p90    
    inclusion:
            LST/LSST
            / cpu_architacture(e.g. COOPER LAKE)
            / cpu_model(e.g. AMD)
            / kernel_version
    exclusion:
            (same as inclusion)
    criticality:
            high/low
} 

*criticality: if high criticality, means when data is missing to a certain level,
it should trigger a sev
```
the goal is to optimize data consumability workflow as:
 {F1983199684}

Differential Revision: D85995164
Summary:

create metricInfo class that contains the following information of metrics:
```
MetricInfo {
    metricName: cpu_time
    handler:
            TwTaskMetricHanlder.getCPUTime()
    validation:
            cpu_time >=0,
            cpu_time <= cpu_time_limit
    granularity: 
            second,
            minute
    aggregation: 
            p99, 
            p90    
    inclusion:
            LST/LSST
            / cpu_architacture(e.g. COOPER LAKE)
            / cpu_model(e.g. AMD)
            / kernel_version
    exclusion:
            (same as inclusion)
    criticality:
            high/low
} 

*criticality: if high criticality, means when data is missing to a certain level,
it should trigger a sev
```
the goal is to optimize data consumability workflow as:
 {F1983199684}

Differential Revision: D85995164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant