Schematized Monitor part1 - Create MetricInfo in MetricFrameBase - #467
Open
cmgrace wants to merge 1 commit into
Open
Schematized Monitor part1 - Create MetricInfo in MetricFrameBase#467cmgrace wants to merge 1 commit into
cmgrace wants to merge 1 commit into
Conversation
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
Summary:
create metricInfo class that contains the following information of metrics:
```
MetricInfo {
metricName: cpu_time
handler:
TwTaskMetricHanlder.getCPUTime()
validation:
cpu_time >=0,
cpu_time <= cpu_time_limit
granularity:
second,
minute
aggregation:
p99,
p90
inclusion:
LST/LSST
/ cpu_architacture(e.g. COOPER LAKE)
/ cpu_model(e.g. AMD)
/ kernel_version
exclusion:
(same as inclusion)
criticality:
high/low
}
*criticality: if high criticality, means when data is missing to a certain level,
it should trigger a sev
```
the goal is to optimize data consumability workflow as:
{F1983199684}
Differential Revision: D85995164
facebook-github-bot
force-pushed
the
export-D85995164
branch
from
November 3, 2025 23:04
c952ee9 to
ed272a7
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
Summary:
create metricInfo class that contains the following information of metrics:
```
MetricInfo {
metricName: cpu_time
handler:
TwTaskMetricHanlder.getCPUTime()
validation:
cpu_time >=0,
cpu_time <= cpu_time_limit
granularity:
second,
minute
aggregation:
p99,
p90
inclusion:
LST/LSST
/ cpu_architacture(e.g. COOPER LAKE)
/ cpu_model(e.g. AMD)
/ kernel_version
exclusion:
(same as inclusion)
criticality:
high/low
}
*criticality: if high criticality, means when data is missing to a certain level,
it should trigger a sev
```
the goal is to optimize data consumability workflow as:
{F1983199684}
Differential Revision: D85995164
facebook-github-bot
force-pushed
the
export-D85995164
branch
from
November 3, 2025 23:44
ed272a7 to
404f4bd
Compare
Summary:
create metricInfo class that contains the following information of metrics:
```
MetricInfo {
metricName: cpu_time
handler:
TwTaskMetricHanlder.getCPUTime()
validation:
cpu_time >=0,
cpu_time <= cpu_time_limit
granularity:
second,
minute
aggregation:
p99,
p90
inclusion:
LST/LSST
/ cpu_architacture(e.g. COOPER LAKE)
/ cpu_model(e.g. AMD)
/ kernel_version
exclusion:
(same as inclusion)
criticality:
high/low
}
*criticality: if high criticality, means when data is missing to a certain level,
it should trigger a sev
```
the goal is to optimize data consumability workflow as:
{F1983199684}
Differential Revision: D85995164
facebook-github-bot
force-pushed
the
export-D85995164
branch
from
November 4, 2025 19:04
404f4bd to
e60659f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
create metricInfo class that contains the following information of metrics:
the goal is to optimize data consumability workflow as:
{F1983199684}
Differential Revision: D85995164