Introducing flag to unescape subst string#42
Introducing flag to unescape subst string#42assarbad wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
|
Hi @assarbad! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Signed the CLA. |
assarbad
force-pushed
the
escape-substitution-string
branch
from
fc4d4f5 to
9294bb1
Compare
|
Sorry, had forgotten to run |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
the import failed due to conflicts |
- This introduces the -S / --subst-escapes flag which will unescape the substitution string prior to performing the substitution. - Allows to work without the help of a shell or with shells incapable of passing substitution string arguments with certain special characters. - Special characters implemented are \t, \n, \r, '\ ' (blank space), \", \$, \', \\, \` - Added test cases for the newly added code. - Bumped the version number in Cargo.toml - Ran 'cargo fmt' on the code
assarbad
force-pushed
the
escape-substitution-string
branch
from
9294bb1 to
d3270fe
Compare
@swolchok Yep, maybe you can hold it for a bit. I'd like to address whatever review comments you say you had, then recommit (i.e. amend). Alas, they're not visible to me (see also other comment on #13 ... may take a few more minutes to finish). |
3 participants
-S/--subst-escapesflag which will unescape the substitution string prior to performing the substitution.\t,\n,\r,'\ '(blank space),\",\$,\',\\,\`Cargo.tomlIt's a new flag so as not to break backwards compatibility.
If merged, this addresses #13 and #31.
If any changes are required, please advise and I will resubmit by force-pushing another signed commit.