Bump thrift-http to 0.3.0.0; update CHANGELOG - #173
Open
simonmar wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@CatherineGasnier has imported this pull request. If you are a Meta employee, you can view this in D115059080. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Aug 7, 2026
Summary: Fixing outstanding issues causing CI failures. Fixes: 1. use of structured annotations in hsthrift test files. This keeps happening due to upstream codemods, so I'm trying to fix it so that future codemods won't break things by importing the upstream thrift/annotation directory into the repo. 2. fix a couple of issues with folly 3. Add caching of C++ dependencies to reduce CI latency Note: stacked on top of #173 Pull Request resolved: #174 Test Plan: ShipIt mapping (D115057268): `conf build` -> `Compilation succeeded`, and `codesync test-configs --project="facebookincubator/hsthrift"` -> `PASS`, including the added mapping test cases showing `fbcode/thrift/annotation/thrift.thrift` maps to `thrift/annotation/thrift.thrift` and `fbcode/thrift/annotation/BUCK` is `__UNMAPPED__`. This diff: `arc lint --rev .^` -> `ok No lint issues.`, so the three land-blocking lint signals (`thrift-duplicate-uri`, `deprecated-java-namespace`, `incorrect-license`) are gone. Case-conflict scan over the whole `fbcode/common/hs/thrift/**` tree at this revision, grouping every path component by its lowercased form: `CLEAN - no case conflicts`. This is the check that the previous land attempt failed. `make -n --always-make thrift-hs` confirms the rewritten recipes expand to ` --hs thrift/annotation/thrift.thrift -o lib/test`, i.e. the same shell variable form as the surrounding untouched invocations, run from the repo root. Verified the dropped annotation copies were redundant internally: `compiler/test/BUCK` already depends on the canonical `//thrift/annotation:thrift`, so no internal target referenced the removed paths. Verified the two annotation files the Makefile compiles (`thrift.thrift`, `scope.thrift`) were byte-identical between the removed copies and the canonical directory. Not verified locally: the OSS getdeps build, which can only resolve `thrift/annotation/` after export. Note the pre-existing `oss-hsthrift-linux-getdeps` and `oss-glean-linux-getdeps` signals fail for an unrelated reason — `cabal update` gets `curl: (56) Received HTTP code 403 from proxy after CONNECT` — an fwdproxy issue in a shared error cluster affecting many diffs, not caused by this change. Reviewed By: phlalx Differential Revision: D115033785 Pulled By: CatherineGasnier fbshipit-source-id: a2e336b058e80c2ade526e9d30b4ec05fa3ef9e0
meta-codesync Bot
pushed a commit
to facebookincubator/Glean
that referenced
this pull request
Aug 19, 2026
Summary: LAND THIS FIRST: facebookincubator/hsthrift#173 Pull Request resolved: #697 Reviewed By: CatherineGasnier Differential Revision: D116370950 Pulled By: phlalx fbshipit-source-id: f4be9a74ebebb3cd249befb33d76348764a4e6bd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.