Build pymomentum on Windows #238
Closed
+4,985
−1,178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
5 tasks
jeongseok-meta
force-pushed
the
pytorch_win
branch
10 times, most recently
from
b5fca20 to
c615556
Compare
|
@jeongseok-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
Summary: Now that the [PyTorch conda package is available on Windows](conda-forge/pytorch-cpu-feedstock#231), we can enable building PyMomentum on this platform. ## Checklist: - [x] Adheres to the [style guidelines](https://facebookincubator.github.io/momentum/docs/developer_guide/style_guide) - [x] Codebase formatted by running `pixi run lint` Test Plan: CI on Windows Differential Revision: D71858372 Pulled By: jeongseok-meta
facebook-github-bot
force-pushed
the
pytorch_win
branch
from
c615556 to
ae1b2c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71858372 |
jeongseok-meta
added a commit
that referenced
this pull request
Mar 26, 2025
Summary: Now that the [PyTorch conda package is available on Windows](conda-forge/pytorch-cpu-feedstock#231), we can enable building PyMomentum on this platform. - [x] Adheres to the [style guidelines](https://facebookincubator.github.io/momentum/docs/developer_guide/style_guide) - [x] Codebase formatted by running `pixi run lint` Test Plan: CI on Windows Differential Revision: D71858372 Pulled By: jeongseok-meta
jeongseok-meta
force-pushed
the
pytorch_win
branch
2 times, most recently
from
3fa9ade to
4b9f47e
Compare
jeongseok-meta
added a commit
that referenced
this pull request
Mar 26, 2025
Summary: Now that the [PyTorch conda package is available on Windows](conda-forge/pytorch-cpu-feedstock#231), we can enable building PyMomentum on this platform. - [x] Adheres to the [style guidelines](https://facebookincubator.github.io/momentum/docs/developer_guide/style_guide) - [x] Codebase formatted by running `pixi run lint` Test Plan: CI on Windows Differential Revision: D71858372 Pulled By: jeongseok-meta
|
@jeongseok-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
force-pushed
the
pytorch_win
branch
from
c328ace to
81a7dd2
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
Summary: Now that the [PyTorch conda package is available on Windows](conda-forge/pytorch-cpu-feedstock#231), we can enable building PyMomentum on this platform. ## Checklist: - [x] Adheres to the [style guidelines](https://facebookincubator.github.io/momentum/docs/developer_guide/style_guide) - [x] Codebase formatted by running `pixi run lint` Test Plan: CI on Windows Differential Revision: D71858372 Pulled By: jeongseok-meta
|
This pull request was exported from Phabricator. Differential Revision: D71858372 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
Summary: Now that the [PyTorch conda package is available on Windows](conda-forge/pytorch-cpu-feedstock#231), we can enable building PyMomentum on this platform. ## Checklist: - [x] Adheres to the [style guidelines](https://facebookincubator.github.io/momentum/docs/developer_guide/style_guide) - [x] Codebase formatted by running `pixi run lint` Test Plan: CI on Windows Differential Revision: D71858372 Pulled By: jeongseok-meta
facebook-github-bot
force-pushed
the
pytorch_win
branch
from
81a7dd2 to
4e4139d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71858372 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
Summary: Now that the [PyTorch conda package is available on Windows](conda-forge/pytorch-cpu-feedstock#231), we can enable building PyMomentum on this platform. ## Checklist: - [x] Adheres to the [style guidelines](https://facebookincubator.github.io/momentum/docs/developer_guide/style_guide) - [x] Codebase formatted by running `pixi run lint` Test Plan: CI on Windows Differential Revision: D71858372 Pulled By: jeongseok-meta
facebook-github-bot
force-pushed
the
pytorch_win
branch
from
4e4139d to
ac6b99c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71858372 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
Summary: Now that the [PyTorch conda package is available on Windows](conda-forge/pytorch-cpu-feedstock#231), we can enable building PyMomentum on this platform. ## Checklist: - [x] Adheres to the [style guidelines](https://facebookincubator.github.io/momentum/docs/developer_guide/style_guide) - [x] Codebase formatted by running `pixi run lint` Test Plan: CI on Windows Differential Revision: D71858372 Pulled By: jeongseok-meta
facebook-github-bot
force-pushed
the
pytorch_win
branch
from
ac6b99c to
149d0a0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71858372 |
Summary: Now that the [PyTorch conda package is available on Windows](conda-forge/pytorch-cpu-feedstock#231), we can enable building PyMomentum on this platform. ## Checklist: - [x] Adheres to the [style guidelines](https://facebookincubator.github.io/momentum/docs/developer_guide/style_guide) - [x] Codebase formatted by running `pixi run lint` Test Plan: CI on Windows Differential Revision: D71858372 Pulled By: jeongseok-meta
facebook-github-bot
force-pushed
the
pytorch_win
branch
from
149d0a0 to
cd44b80
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71858372 |
|
@jeongseok-meta merged this pull request in bbdd9fa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that the PyTorch conda package is available on Windows, we can enable building PyMomentum on this platform.
Checklist:
pixi run lintTest Plan
CI on Windows