feat: Add per-column decode cost collection in Nimble reader#558
Open
kewang1024 wants to merge 1 commit intofacebookincubator:mainfrom
Open
feat: Add per-column decode cost collection in Nimble reader#558kewang1024 wants to merge 1 commit intofacebookincubator:mainfrom
kewang1024 wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@kewang1024 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95745946. |
kewang1024
changed the title
kewang1024
pushed a commit
to kewang1024/nimble
that referenced
this pull request
Mar 10, 2026
…bookincubator#558) Summary: Initialize columnMetricsSet in SelectiveNimbleRowReader when collectColumnStats is enabled and merge stats in updateRuntimeStats(). This enables the common readWithTiming() path to collect decodeCPUTimeNanos per column, matching DWRF (D94338919, D94979517, D94554467). Differential Revision: D95745946
kewang1024
force-pushed
the
export-D95745946
branch
from
81e1bde to
cd4453f
Compare
kewang1024
pushed a commit
to kewang1024/nimble
that referenced
this pull request
Mar 10, 2026
…bookincubator#558) Summary: Initialize columnMetricsSet in SelectiveNimbleRowReader when collectColumnStats is enabled and merge stats in updateRuntimeStats(). This enables the common readWithTiming() path to collect decodeCPUTimeNanos per column, matching DWRF (D94338919, D94979517, D94554467). Differential Revision: D95745946
kewang1024
force-pushed
the
export-D95745946
branch
from
cd4453f to
1922d92
Compare
kewang1024
changed the title
kewang1024
pushed a commit
to kewang1024/nimble
that referenced
this pull request
Mar 10, 2026
…kincubator#558) Summary: Initialize columnMetricsSet in SelectiveNimbleRowReader when collectColumnStats is enabled and merge stats in updateRuntimeStats(). This enables the common readWithTiming() path to collect decodeCPUTimeNanos per column, matching DWRF (D94338919, D94979517, D94554467). Differential Revision: D95745946
kewang1024
force-pushed
the
export-D95745946
branch
from
1922d92 to
4ca886c
Compare
…kincubator#558) Summary: Pull Request resolved: facebookincubator#558 Initialize columnMetricsSet in SelectiveNimbleRowReader when collectColumnStats is enabled and merge stats in updateRuntimeStats(). This enables the common readWithTiming() path to collect decodeCPUTimeNanos per column, matching DWRF (D94338919, D94979517, D94554467). Differential Revision: D95745946
kewang1024
force-pushed
the
export-D95745946
branch
from
4ca886c to
ae2b2ed
Compare
xiaoxmeng
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Initialize columnMetricsSet in SelectiveNimbleRowReader when
collectColumnStats is enabled and merge stats in updateRuntimeStats().
This enables the common readWithTiming() path to collect
decodeCPUTimeNanos per column, matching DWRF (D94338919, D94979517,
D94554467).
Differential Revision: D95745946