-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to do map->flatmap and then passthrough that same flatmap #89
base: main
Are you sure you want to change the base?
Commits on Sep 26, 2024
-
Allow for dictionary encoded vector ingestion
Summary: Allows for already encoded dictionaries to passthrough the writer as opposed to being decoded + deduped again. Specifically, we want to allow for a "passthrough" without decoding when the schema indicates that we are ingesting an ArrayVector, but the array we find is a dictionaryVector with ArrayVector values. When this is the case, we will check to see if the dictionary is a valid run-length encoding (meaning, it likely has been deduped by upstream). The way in which the vector is written to storage does not change, we will still write the offsets and the ArrayVector elements. A caveat is that right now, `isDictionaryValidRunLengthEncoded` function doesn't actually verify that there is a duplicate. It's possible that a scenario exists in which a DictionaryVector was passed to the ArrayVector field writer, but the DictionaryVector has not been deduped, but its offsets still technically fulfill a run-length encoding (each offset is greater than or equal to the offset at index - 1). Reviewed By: helfman Differential Revision: D59863671
Configuration menu - View commit details
-
Copy full SHA for 8246c40 - Browse repository at this point
Copy the full SHA 8246c40View commit details -
Add callback functionality to Options/Context to capture visits to ge…
…tLocalDecodedVector Summary: As title, in order to verify passthrough code is being correctly called and the local decoded vector is NOT being accessed, we need a way to track visits to the decode function. On suggestion/idea by helfman, we've created a visit callback passed in via the writer options which allows us to track if the decode visit has been called from the writer code. I did verify that the callback is being called through some tests that I know _do_ use the decode functionality. I plan to add decode visit counters for those tests later but that is out of scope for this diff for now This decode visit functionality will be used in the flatmap passthrough functionality as well Reviewed By: helfman Differential Revision: D60241883
Configuration menu - View commit details
-
Copy full SHA for 0681875 - Browse repository at this point
Copy the full SHA 0681875View commit details -
Add caching support for dictionary encoded passthrough
Summary: Allows for caching of the last element when a dictionary encoded array is given for passthrough. This will bring us up to parity of local file encoding with the original arrayWithOffsets, as two consecutive datasets, either passed as unencoded array or already encoded dictionaryArray will now have the same output into the file. Reviewed By: helfman Differential Revision: D60413733
Configuration menu - View commit details
-
Copy full SHA for ee3124a - Browse repository at this point
Copy the full SHA ee3124aView commit details -
Allow for flatmap passthrough in the FieldWriter
Summary: As title, allows for ingestion of RowVector in the FlatMapFieldWriter. Takes each item in the row and writes its child vector based on the ranges provided. Currently not handled: - Encoded row vectors with flatmap schema - What happens when there are subsequent writes that have a different set of keys from the original write Reviewed By: helfman Differential Revision: D61456412
Configuration menu - View commit details
-
Copy full SHA for 46a7d80 - Browse repository at this point
Copy the full SHA 46a7d80View commit details -
Add test to do map->flatmap and then passthrough that same flatmap
Summary: Test that creates a fuzz map, writes it to a nimble file with flatmap encoding turned on, then reads it back and writes the same vector again. Test ensures that the two paths map input ->flatmap vector to write and flatmap input->flatmap vector to write have the same right side output Reviewed By: helfman Differential Revision: D62110004
Configuration menu - View commit details
-
Copy full SHA for 47c51a0 - Browse repository at this point
Copy the full SHA 47c51a0View commit details