Honor an optional auth value for keys on Linux - #10
Open
paulofduarte wants to merge 1 commit into
Open
Conversation
NewKey and FromLabelTag take a WithAuthValue option that, on Linux, sets a TPM authValue on the key when it is created and requires it to sign. macOS and Windows ignore it; the presence-less behaviour is unchanged when no value is given.
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux backend ignores useBiometrics because the TPM has no biometric prompt,
so there is no way to require user presence to sign with a key.
This adds a WithAuthValue option to NewKey and FromLabelTag. On Linux the value
is set as the TPM auth value when the key is created and is then required to sign
with it. macOS and Windows ignore it, so existing callers are unaffected.
A note on naming: useBiometrics reads oddly now that it gates a PIN-style value on
Linux. If you would prefer, I am happy to rename it to checkPresence (or similar)
in a follow-up.
Tested with the TPM simulator (sign succeeds with the right value, fails with a
wrong one) plus an option-plumbing test that runs everywhere.