Skip to content

Add tt.GatherOp support - #12

Closed
enjustli wants to merge 1 commit into
facebookincubator:mainfrom
enjustli:fork_ms_pr_354
Closed

Add tt.GatherOp support#12
enjustli wants to merge 1 commit into
facebookincubator:mainfrom
enjustli:fork_ms_pr_354

Conversation

@enjustli

Copy link
Copy Markdown
Contributor

fork from microsoft/triton-shared#354

Added support for triton::GatherOp conversion. Using cf.assert for out-of-bound indices, consistent with the CUDA backend behavior (which triggers a device assert).

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 31, 2026
@enjustli

enjustli commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

I still think we shouldn't directly convert tt.gather to linalg.generic; that's too abrupt. and it will lose useful information. @nhat-nguyen

@enjustli

enjustli commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

Since there are legal risks, i will rewrite the code with the original PR as a reference.

@enjustli enjustli closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant