Skip to content

Fix flaky build: add TPtrIR dependency to TritonShared plugin - #20

Open
erwei-xilinx wants to merge 1 commit into
facebookincubator:mainfrom
erwei-xilinx:fix-tptr-tablegen-dependency
Open

Fix flaky build: add TPtrIR dependency to TritonShared plugin#20
erwei-xilinx wants to merge 1 commit into
facebookincubator:mainfrom
erwei-xilinx:fix-tptr-tablegen-dependency

Conversation

@erwei-xilinx

Copy link
Copy Markdown

Summary

  • Adds TPtrIR to LINK_LIBS of the TritonShared plugin target in the root CMakeLists.txt

The TritonShared pybind plugin includes TPtrDialect.h (via triton_shared.cc), which requires the tablegen-generated TPtrDialect.h.inc. Without an explicit dependency on TPtrIR (which depends on TPtrTableGen), parallel builds (-j8) can schedule the .cc.o compilation before the .h.inc file is generated, causing:

fatal error: 'triton-shared/Dialect/TPtr/IR/TPtrDialect.h.inc' file not found

Fixes #19

Test plan

  • Verified the fix resolves the flaky build in downstream CI (amd/Triton-XDNA)

🤖 Generated with Claude Code

@meta-cla

meta-cla Bot commented Apr 11, 2026

Copy link
Copy Markdown

Hi @erwei-xilinx!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

The TritonShared pybind plugin includes TPtrDialect.h (via
triton_shared.cc), which requires the tablegen-generated
TPtrDialect.h.inc. Without an explicit dependency on TPtrIR (which
depends on TPtrTableGen), parallel builds can schedule the .cc.o
compilation before the .h.inc file is generated, causing:

  fatal error: 'triton-shared/Dialect/TPtr/IR/TPtrDialect.h.inc'
  file not found

Fixes facebookincubator#19

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TritonShared plugin missing dependency on TPtrTableGen

1 participant