Skip to content

Bump to triton-lang/triton@142586f90aac - #39

Merged
nhat-nguyen merged 5 commits into
facebookincubator:mainfrom
steplong:bump-triton
Aug 12, 2026
Merged

Bump to triton-lang/triton@142586f90aac#39
nhat-nguyen merged 5 commits into
facebookincubator:mainfrom
steplong:bump-triton

Conversation

@steplong

@steplong steplong commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Assisted by claude

@meta-cla

meta-cla Bot commented Aug 6, 2026

Copy link
Copy Markdown

Hi @steplong!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Aug 6, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 6, 2026
@steplong

steplong commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Not sure about these python/examples changes

@steplong

steplong commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@nhat-nguyen

@steplong

Copy link
Copy Markdown
Contributor Author

Looks like the integration tests are failing because it requires nanobind

@nhat-nguyen

nhat-nguyen commented Aug 10, 2026 via email

Copy link
Copy Markdown
Contributor

@steplong

steplong commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

I also meant to ask the same thing, why are we changing to nanobind?

Triton switched to nanobind here triton-lang/triton@ec2b084

@nhat-nguyen

nhat-nguyen commented Aug 10, 2026 via email

Copy link
Copy Markdown
Contributor

@steplong

Copy link
Copy Markdown
Contributor Author

I changed the python/examples to use make_tensor_descriptor instead. Had to change the block sizes because make_tensor_descriptor requires at least 16 bytes in the last dimension of the block shape

@nhat-nguyen
nhat-nguyen merged commit 0c27923 into facebookincubator:main Aug 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants