Skip to content

fix(cuDF): ExpressionEvaluator was not declared in this scope #15366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(cuDF): ExpressionEvaluator was not declared in this scope #15366

wants to merge 1 commit into from
+9 −9

Conversation

@karthikeyann
Copy link
Collaborator

@karthikeyann karthikeyann commented Nov 1, 2025 •
edited by majetideepak
Loading

This PR fixes the recent CI build
https://github.com/facebookincubator/velox/actions/runs/19030255736/job/54342240691

cudf/exec/CudfHashJoin.cpp:626:26: error: 'ExpressionEvaluator' was not declared in this scope;

2 PRs were merged around same time and 2 merges together caused an issue.

@karthikeyann karthikeyann requested a review from MBkkt November 1, 2025 16:19
@netlify
Copy link

netlify bot commented Nov 1, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 06bc38e
🔍 Latest deploy log https://app.netlify.com/projects/meta-velox/deploys/690633323bfc9c0008a4150c

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 1, 2025
@karthikeyann karthikeyann changed the title fix: Fix CI break due to 2 PRs refactor merge fix: Fix compile error in CI Nov 1, 2025
@karthikeyann karthikeyann requested a review from kgpai November 1, 2025 16:23
@meta-codesync
Copy link

meta-codesync bot commented Nov 1, 2025

@kgpai has imported this pull request. If you are a Meta employee, you can view this in D86027180.

@jinchengchenghh jinchengchenghh added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Nov 1, 2025
@jinchengchenghh jinchengchenghh mentioned this pull request Nov 2, 2025
Merged
@zhouyuan zhouyuan mentioned this pull request Nov 3, 2025
Closed
@prestodb-ci
Copy link

@zhouyuan imported this issue as ibm/velox #15366

@majetideepak majetideepak changed the title fix: Fix compile error in CI fix(cuDF): Compile error in CI Nov 3, 2025
@majetideepak majetideepak changed the title fix(cuDF): Compile error in CI fix(cuDF): 'ExpressionEvaluator' was not declared in this scope Nov 3, 2025
@majetideepak majetideepak changed the title fix(cuDF): 'ExpressionEvaluator' was not declared in this scope fix(cuDF): ExpressionEvaluator was not declared in this scope Nov 3, 2025
@meta-codesync meta-codesync bot closed this in 8398571 Nov 3, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 3, 2025

@kgpai merged this pull request in 8398571.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devavret devavret devavret approved these changes

@MBkkt MBkkt MBkkt approved these changes

@jinchengchenghh jinchengchenghh jinchengchenghh approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner

@mhaseeb123 mhaseeb123 Awaiting requested review from mhaseeb123 mhaseeb123 is a code owner

@kgpai kgpai Awaiting requested review from kgpai

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@karthikeyann @prestodb-ci @devavret @MBkkt @jinchengchenghh @facebook-github-bot