test: Add PrintTo for test param structs to improve gtest output (#16796)#16796
Open
pedroerp wants to merge 1 commit intofacebookincubator:mainfrom
Open
test: Add PrintTo for test param structs to improve gtest output (#16796)#16796pedroerp wants to merge 1 commit intofacebookincubator:mainfrom
pedroerp wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
pedroerp
changed the title
Contributor
|
Builds are failing |
meta-codesync
bot
changed the title
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Mar 17, 2026
…ebookincubator#16796) Summary: Add `PrintTo` overloads for parameterized test structs that were missing them. Without these, gtest falls back to dumping raw bytes in diagnostic output (e.g. `# GetParam() = 16-byte object <01-00 00-00 ...>`), making CI logs hard to read. Structs updated: - SpillerTest::TestParam (delegates to toString()) - HashJoinBridgeTest::TestParam (probers:N_builders:M) - OutputBufferManagerTest::TestParam (kind_serde) - SpillTest::TestParam (delegates to toString()) - MinMaxByAggregationTest::TestParam (valueType_comparisonType) - RawVectorTest::TestParam (withPool/noPool) - TestColumnReader: ReaderTestParams, NonSelectiveReaderTestParams, SchemaMismatchTestParam (all delegate to toString()) - ConfigTests::ConfigTestParams (cols:inputCols) Differential Revision: D96759255
pedroerp
force-pushed
the
export-D96759255
branch
from
3635733 to
dd64f8c
Compare
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Mar 17, 2026
…ebookincubator#16796) Summary: Add `PrintTo` overloads for parameterized test structs that were missing them. Without these, gtest falls back to dumping raw bytes in diagnostic output (e.g. `# GetParam() = 16-byte object <01-00 00-00 ...>`), making CI logs hard to read. Structs updated: - SpillerTest::TestParam (delegates to toString()) - HashJoinBridgeTest::TestParam (probers:N_builders:M) - OutputBufferManagerTest::TestParam (kind_serde) - SpillTest::TestParam (delegates to toString()) - MinMaxByAggregationTest::TestParam (valueType_comparisonType) - RawVectorTest::TestParam (withPool/noPool) - TestColumnReader: ReaderTestParams, NonSelectiveReaderTestParams, SchemaMismatchTestParam (all delegate to toString()) - ConfigTests::ConfigTestParams (cols:inputCols) Differential Revision: D96759255
pedroerp
force-pushed
the
export-D96759255
branch
from
dd64f8c to
49f40d5
Compare
…ebookincubator#16796) Summary: Pull Request resolved: facebookincubator#16796 Add `PrintTo` overloads for parameterized test structs that were missing them. Without these, gtest falls back to dumping raw bytes in diagnostic output (e.g. `# GetParam() = 16-byte object <01-00 00-00 ...>`), making CI logs hard to read. Structs updated: - SpillerTest::TestParam (delegates to toString()) - HashJoinBridgeTest::TestParam (probers:N_builders:M) - OutputBufferManagerTest::TestParam (kind_serde) - SpillTest::TestParam (delegates to toString()) - MinMaxByAggregationTest::TestParam (valueType_comparisonType) - RawVectorTest::TestParam (withPool/noPool) - TestColumnReader: ReaderTestParams, NonSelectiveReaderTestParams, SchemaMismatchTestParam (all delegate to toString()) - ConfigTests::ConfigTestParams (cols:inputCols) Differential Revision: D96759255
pedroerp
force-pushed
the
export-D96759255
branch
from
49f40d5 to
8cbf091
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add
PrintTooverloads for parameterized test structs that were missingthem. Without these, gtest falls back to dumping raw bytes in diagnostic
output (e.g.
# GetParam() = 16-byte object <01-00 00-00 ...>), makingCI logs hard to read.
Structs updated:
SchemaMismatchTestParam (all delegate to toString())
Differential Revision: D96759255