[draft] Fix missing parquet writer link in iceberg splitreader CMake#16877
Draft
amitkdutta wants to merge 1 commit intofacebookincubator:mainfrom
Draft
[draft] Fix missing parquet writer link in iceberg splitreader CMake#16877amitkdutta wants to merge 1 commit intofacebookincubator:mainfrom
amitkdutta wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Summary: The `velox_hive_iceberg_splitreader` library conditionally compiles `IcebergParquetStatsCollector.cpp` when `VELOX_ENABLE_PARQUET` is ON, and `IcebergDataSink.cpp` uses `parquet::WriterOptions`. However, the CMakeLists.txt only linked `velox_dwio_parquet_field_id` (a header-only interface library), not the actual `velox_dwio_parquet_writer` that provides the parquet writer and arrow metadata symbols. This caused undefined reference linker errors when building `presto_to_velox_connector_test` (and other targets linking `velox_hive_iceberg_splitreader`) in presto-native-execution: - `typeinfo for facebook::velox::parquet::WriterOptions` - `facebook::velox::parquet::arrow::FileMetaData::numRows()` - `facebook::velox::parquet::arrow::RowGroupMetaData::numColumns()` - and several other parquet arrow metadata symbols Fix: conditionally link `velox_dwio_parquet_writer` when `VELOX_ENABLE_PARQUET` is enabled, following the same pattern used in `velox/connectors/hive/tests/CMakeLists.txt`. Differential Revision: D97626196
meta-cla
bot
added
the
CLA Signed
|
@amitkdutta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97626196. |
✅ Deploy Preview for meta-velox canceled.
|
amitkdutta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
velox_hive_iceberg_splitreaderlibrary conditionally compilesIcebergParquetStatsCollector.cppwhenVELOX_ENABLE_PARQUETis ON,and
IcebergDataSink.cppusesparquet::WriterOptions. However, theCMakeLists.txt only linked
velox_dwio_parquet_field_id(a header-onlyinterface library), not the actual
velox_dwio_parquet_writerthatprovides the parquet writer and arrow metadata symbols.
This caused undefined reference linker errors when building
presto_to_velox_connector_test(and other targets linkingvelox_hive_iceberg_splitreader) in presto-native-execution:typeinfo for facebook::velox::parquet::WriterOptionsfacebook::velox::parquet::arrow::FileMetaData::numRows()facebook::velox::parquet::arrow::RowGroupMetaData::numColumns()Fix: conditionally link
velox_dwio_parquet_writerwhenVELOX_ENABLE_PARQUETis enabled, following the same pattern used invelox/connectors/hive/tests/CMakeLists.txt.Differential Revision: D97626196