Skip to content

feat(cudf): Add cudf label to cudf pull request#16976

Open
jinchengchenghh wants to merge 9 commits intofacebookincubator:mainfrom
jinchengchenghh:cudf_label
Open

feat(cudf): Add cudf label to cudf pull request#16976
jinchengchenghh wants to merge 9 commits intofacebookincubator:mainfrom
jinchengchenghh:cudf_label

Conversation

@jinchengchenghh
Copy link
Copy Markdown
Collaborator

@jinchengchenghh jinchengchenghh commented Mar 31, 2026

No description provided.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 31, 2026 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 2dd9790
🔍 Latest deploy log https://app.netlify.com/projects/meta-velox/deploys/69cbcd7af972260008b4b77b

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 31, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026 •
edited
Loading

Build Impact Analysis

No build targets affected by this change.

Fast path • Graph from main@c88427de2e64291c6f18933ec35d3d31d3edc735

@jinchengchenghh jinchengchenghh marked this pull request as draft March 31, 2026 12:34
@jinchengchenghh jinchengchenghh changed the title feat(cudf): Add cudf label to cudf pull request feat(cudf): Add cudf label to cudf pull request Mar 31, 2026
@jinchengchenghh jinchengchenghh changed the title feat(cudf): Add cudf label to cudf pull request feat(cudf): Add cudf label to cudf pull request Mar 31, 2026
@jinchengchenghh jinchengchenghh changed the title feat(cudf): Add cudf label to cudf pull request feat(cudf): Add cudf label to cudf pull request Mar 31, 2026
@jinchengchenghh jinchengchenghh changed the title feat(cudf): Add cudf label to cudf pull request feat(cudf): Add cudf label to cudf pull request Mar 31, 2026
@devavret
Copy link
Copy Markdown
Collaborator

devavret commented Mar 31, 2026

Thanks for this. It's been on our mind to do this for a while. But unfortunately I cannot review since I'm not experienced with github workflows.

jinchengchenghh
jinchengchenghh commented Mar 31, 2026
View reviewed changes
jinchengchenghh
jinchengchenghh commented Mar 31, 2026
View reviewed changes
.github/workflows/labeler.yml
name: Labeler

on:
pull_request_target:
Copy link
Copy Markdown
Collaborator Author

@jinchengchenghh jinchengchenghh Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With pull_request_target, GitHub always runs the workflow from the base branch (e.g., main), not from your PR branch.

@jinchengchenghh jinchengchenghh marked this pull request as ready for review March 31, 2026 13:02
@jinchengchenghh
Copy link
Copy Markdown
Collaborator Author

jinchengchenghh commented Mar 31, 2026

Thanks for your reply, please make sure the feature worked as you expect, I will ask Meta to verify the semantics. @devavret

@jinchengchenghh
Copy link
Copy Markdown
Collaborator Author

jinchengchenghh commented Mar 31, 2026

The label feature worked as Gluten labels.

@jinchengchenghh
Copy link
Copy Markdown
Collaborator Author

jinchengchenghh commented Apr 1, 2026

Hi, @kgpai , this feature is cudf team want to do, it must take effect after it merged to main since it runs on pull_request_target to access the secret token, could you help merge it? And then we can verify if it worked as we expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

@devavret devavret Awaiting requested review from devavret

@karthikeyann karthikeyann Awaiting requested review from karthikeyann

@czentgr czentgr Awaiting requested review from czentgr

@kgpai kgpai Awaiting requested review from kgpai

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jinchengchenghh @devavret