refactor: Migrate production code to ConnectorRegistry API and deprecate free functions (#16986)#16986
Closed
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
Closed
refactor: Migrate production code to ConnectorRegistry API and deprecate free functions (#16986)#16986mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
mbasmanova
requested review from
bdice,
devavret,
karthikeyann,
majetideepak and
mhaseeb123
as code owners
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@mbasmanova has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98963405. |
Build Impact AnalysisFull build recommended. Files outside the dependency graph changed:
These directories are not fully covered by the dependency graph. A full build is the safest option. Fast path • Graph from main@65800681f99ac53fe2cb3d5c121dd8ba611e385b |
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Mar 31, 2026
…ate free functions (facebookincubator#16986) Summary: Pull Request resolved: facebookincubator#16986 Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Differential Revision: D98963405
meta-codesync
bot
changed the title
mbasmanova
force-pushed
the
export-D98963405
branch
from
e3857eb to
a279d6b
Compare
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Mar 31, 2026
…ate free functions (facebookincubator#16986) Summary: Pull Request resolved: facebookincubator#16986 Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Differential Revision: D98963405
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Apr 1, 2026
…ate free functions (facebookincubator#16986) Summary: Pull Request resolved: facebookincubator#16986 Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Differential Revision: D98963405
mbasmanova
force-pushed
the
export-D98963405
branch
2 times, most recently
from
9b85cb7 to
4a3dcf0
Compare
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Apr 1, 2026
…ate free functions (facebookincubator#16986) Summary: Pull Request resolved: facebookincubator#16986 Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Differential Revision: D98963405
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Apr 1, 2026
…ate free functions (facebookincubator#16986) Summary: Pull Request resolved: facebookincubator#16986 Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Differential Revision: D98963405
mbasmanova
force-pushed
the
export-D98963405
branch
from
4a3dcf0 to
e8beaa5
Compare
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Apr 2, 2026
…ate free functions (facebookincubator#16986) Summary: Pull Request resolved: facebookincubator#16986 Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Reviewed By: jagill Differential Revision: D98963405
mbasmanova
force-pushed
the
export-D98963405
branch
from
e8beaa5 to
3bb855d
Compare
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Apr 2, 2026
…ate free functions (facebookincubator#16986) Summary: Pull Request resolved: facebookincubator#16986 Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Reviewed By: jagill Differential Revision: D98963405
mbasmanova
force-pushed
the
export-D98963405
branch
from
3bb855d to
16927b2
Compare
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Apr 2, 2026
…ate free functions (facebookincubator#16986) Summary: Pull Request resolved: facebookincubator#16986 Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Reviewed By: jagill Differential Revision: D98963405
mbasmanova
force-pushed
the
export-D98963405
branch
from
16927b2 to
754cd00
Compare
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Apr 2, 2026
…ate free functions (facebookincubator#16986) Summary: Pull Request resolved: facebookincubator#16986 Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Reviewed By: jagill Differential Revision: D98963405
mbasmanova
force-pushed
the
export-D98963405
branch
from
754cd00 to
7b06497
Compare
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Apr 2, 2026
…ate free functions (facebookincubator#16986) Summary: Pull Request resolved: facebookincubator#16986 Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Reviewed By: jagill Differential Revision: D98963405
mbasmanova
force-pushed
the
export-D98963405
branch
2 times, most recently
from
f98b381 to
bd3cdb6
Compare
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Apr 3, 2026
…ate free functions (facebookincubator#16986) Summary: Pull Request resolved: facebookincubator#16986 Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Reviewed By: jagill Differential Revision: D98963405
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Apr 3, 2026
…ate free functions (facebookincubator#16986) Summary: Pull Request resolved: facebookincubator#16986 Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Reviewed By: jagill Differential Revision: D98963405
mbasmanova
force-pushed
the
export-D98963405
branch
from
bd3cdb6 to
a888f5c
Compare
mbasmanova
added a commit
to mbasmanova/velox
that referenced
this pull request
Apr 3, 2026
…ate free functions (facebookincubator#16986) Summary: Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Reviewed By: jagill Differential Revision: D98963405
mbasmanova
force-pushed
the
export-D98963405
branch
from
a888f5c to
f45e92c
Compare
…ate free functions (facebookincubator#16986) Summary: Replace legacy free functions (registerConnector, unregisterConnector, getConnector, hasConnector) with ConnectorRegistry methods in all remaining velox/ production code: TableScan, TableWriter, IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental operators. Mark the free functions [[deprecated]] to prevent new usages. Reviewed By: jagill Differential Revision: D98963405
mbasmanova
force-pushed
the
export-D98963405
branch
from
f45e92c to
8c6f030
Compare
|
This pull request has been merged in 3385988. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace legacy free functions (registerConnector, unregisterConnector,
getConnector, hasConnector) with ConnectorRegistry methods in all
remaining velox/ production code: TableScan, TableWriter,
IndexLookupJoin, TraceReplayRunner, PyConnectors, and experimental
operators.
Mark the free functions [[deprecated]] to prevent new usages.
Reviewed By: jagill
Differential Revision: D98963405