fix(cuDF): Fix debug build failure#17011
Open
pramodsatya wants to merge 2 commits intofacebookincubator:mainfrom
Open
fix(cuDF): Fix debug build failure#17011pramodsatya wants to merge 2 commits intofacebookincubator:mainfrom
pramodsatya wants to merge 2 commits intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Build Impact AnalysisFull build recommended. Files outside the dependency graph changed:
These directories are not fully covered by the dependency graph. A full build is the safest option. Fast path • Graph from main@65800681f99ac53fe2cb3d5c121dd8ba611e385b |
majetideepak
reviewed
Apr 3, 2026
| auto stream = cudf::get_default_stream(); | ||
| auto mr = cudf::get_current_device_resource_ref(); | ||
| auto stream = cudf::get_default_stream(cudf::allow_default_stream); | ||
| auto mr = rmm::mr::get_current_device_resource(); |
Collaborator
There was a problem hiding this comment.
The API at velox/experimental/cudf/CudfNoDefaults.h says we could use get_temp_mr() instead.
@bdice can you please take a look at this fix? Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Build error for T = double:
makeScalarFromValue()inAstUtils.hcallscudf::get_default_stream()andcudf::get_current_device_resource_ref(). When any.cppfile includes bothCudfNoDefaults.handAstUtils.h(e.g.CudfHashJoin.cpp), these calls hit the__attribute__((error))redeclarations that guard against accidental default argument usage.In Release builds (
-O2), GCC's dead-code elimination removes unused template instantiations before the error fires. In Debug builds (-O0), all instantiations are preserved, triggering a hard compile error.Solution
Replaces the two calls with existing approved alternatives:
cudf::get_default_stream()→cudf::get_default_stream(cudf::allow_default_stream)(fromCudfDefaultStreamOverload.h)cudf::get_current_device_resource_ref()→rmm::mr::get_current_device_resource()(direct RMM call, same pattern asget_temp_mr()inCudfNoDefaults.h)Both return identical values at runtime — zero performance impact.
Changes
velox/experimental/cudf/expression/AstUtils.h: UpdatemakeScalarFromValue()to use poison-safe alternatives