fix(nimble): Preserve nulls in dense bulk reads - #18611
Open
MatzeB wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@MatzeB has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116851691. |
Summary: Bugfix: Dense nullable reads using an `AlwaysTrue` visitor could return an all-valid vector even when the input contained nulls. The bulk path now copies the read-range null bitmap when the reader cannot return that buffer directly, then marks the result as nullable. Differential Revision: D116851691
MatzeB
force-pushed
the
export-D116851691
branch
from
August 20, 2026 22:37
3195b6a to
4e3d88c
Compare
Selective Build Plan
Fast path • Graph from main@c3413b270eb5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Bugfix: Dense nullable reads using an
AlwaysTruevisitor could return an all-valid vector even when the input contained nulls. The bulk path now copies the read-range null bitmap when the reader cannot return that buffer directly, then marks the result as nullable.Differential Revision: D116851691