fix: Support merging HUGEINT value filters - #18626
Open
rui-mo wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Selective Build Plan
Affected targets (537)Directly changed (270)
Transitively affected (267)
Fast path • Graph from main@2c661fc83bf7 |
CI Failure Analysis
❌ Build with GCC / TEST: Linux release with adapters — TEST Failure View logsFailed test: The test at line 635 of // Change these once HUGEINT filter merge is fixed.
ASSERT_TRUE(remaining);Correlation with PR changes: This failure is directly caused by the PR changes. The PR implements The test itself anticipated this fix with the comment "Change these once HUGEINT filter merge is fixed". Known issues:
Reproduce locally: ./_build/release/velox/connectors/hive/tests/velox_hive_connector_test \
--gtest_filter="HiveConnectorTest.extractFiltersFromRemainingFilter"Recommended fix: Update the test at // Change these once HUGEINT filter merge is fixed.
ASSERT_TRUE(remaining);
ASSERT_EQ(
remaining->toString(), "not(lt(ROW[\"c2\"],cast(0 as DECIMAL(20, 0))))");with: ASSERT_FALSE(remaining); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Long decimal dynamic filter pushdown now produces
HugeintValuesUsingHashTablefilters. When a runtime dynamic filter is added to a scan column that already
has a filter, Velox merges them using
Filter::mergeWith(). HUGEINT valuefilters did not implement this, so dynamic filter pushdown could fail with the
below exception.
Changes
This PR:
mergeWith()support forHugeintValuesUsingHashTable.mergeWith()support forHugeintRange.Follow-up for: #18159.