fix(nimble): Make the shared dictionary export build and pass checks - #18642
Open
kgpai wants to merge 1 commit into
Open
fix(nimble): Make the shared dictionary export build and pass checks#18642kgpai wants to merge 1 commit into
kgpai wants to merge 1 commit into
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
duxiao1212
approved these changes
Aug 23, 2026
Selective Build Plan
Selective build plan |
xiaoxmeng
approved these changes
Aug 24, 2026
kgpai
force-pushed
the
nimble-shared-dictionary-build-fixes
branch
from
August 24, 2026 03:14
56fedd4 to
34583da
Compare
Contributor
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this in D117152048. |
#18640 exported the shared dictionary work byte-identical to fbcode, which leaves this tree not compiling and failing pre-commit. This fixes that. Four struct members had no default initializer, so every brace-initialization of those structs failed under -Wextra -Werror. fbcode does not promote -Wmissing-field-initializers, so the omissions are invisible internally: - Encoding::Options::sharedDictionaryAlphabet, 196 errors - SharedDictionaryConfig::alphabetEncodings, 5 errors - ExternalDictionaryBuilder::Options::readFactors, 4 errors - ExternalDictionaryBuilder::Options::alphabetEncoding, 1 error ExternalSharedDictionaryBuilder::resetImpl passed a Kind enum to NIMBLE_UNSUPPORTED, and fmt v11 will not format an enum implicitly. Uses the existing kindString() instead, which also turns the message from an integer into "External shared dictionary builder does not support reset()". Four headers had no CMake entry, breaking check-header-ownership. Each is now listed beside the .cpp already in its target. tools/tests/CMakeLists.txt is reformatted by gersemi. It landed unformatted with #18634, and pre-commit runs over all files, so it fails on main too. See #18643 for why this keeps recurring and how to stop it at source.
kgpai
force-pushed
the
nimble-shared-dictionary-build-fixes
branch
from
August 24, 2026 04:02
34583da to
1fd78f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18640 exported the shared dictionary work byte-identical to fbcode, which
leaves this tree not compiling and failing
pre-commit. This fixes that.Encoding::Options::sharedDictionaryAlphabetandSharedDictionaryConfig::alphabetEncodingshad no default initializer, soevery brace-initialization of those structs failed under
-Wextra -Werror.201 errors across six test files.
ExternalSharedDictionaryBuilder::resetImplpassed aKindenum toNIMBLE_UNSUPPORTED; fmt v11 will not format an enum. Uses the existingkindString()instead.check-header-ownership. Each isnow listed beside the
.cppalready in its target.Kept separate from #18640 so the export stays a clean mirror of fbcode.
See #18643 for why this keeps happening and how to stop it at source.