Skip to content

Commit

Permalink
{Feature} AriaDataProvider - GPS - Add vertical accuracy in data record
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookresearch/projectaria_tools#160

This field was missing in the data record

Reviewed By: SeaOtocinclus

Differential Revision: D66671092

fbshipit-source-id: 004515200aef3f3e06d0b323ff5e50980285bc66
  • Loading branch information
Pablo Ramon authored and facebook-github-bot committed Dec 4, 2024
1 parent e15b7ff commit c8c030d
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 7 deletions.
3 changes: 3 additions & 0 deletions src/data_provider/data_layout/aria/GpsMetadata.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ struct GpsDataRecordMetadata : public vrs::AutoDataLayout {
// Horizontal accuracy in meters
vrs::DataPieceValue<float> accuracy{"accuracy"};

// Vertical accuracy in meters
vrs::DataPieceValue<float> verticalAccuracy{"vertical_accuracy"};

// Speed over ground [m/s]
vrs::DataPieceValue<float> speed{"speed"};

Expand Down
1 change: 1 addition & 0 deletions src/data_provider/players/AriaGpsPlayer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ bool AriaGpsPlayer::onDataLayoutRead(
dataRecord_.longitude = data.longitude.get();
dataRecord_.altitude = data.altitude.get();
dataRecord_.accuracy = data.accuracy.get();
dataRecord_.verticalAccuracy = data.verticalAccuracy.get();
dataRecord_.speed = data.speed.get();
data.rawData.get(dataRecord_.rawData);
nextTimestampSec_ = std::nextafter(r.timestamp, std::numeric_limits<double>::max());
Expand Down
15 changes: 8 additions & 7 deletions src/data_provider/players/AriaGpsPlayer.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,14 @@ struct AriaGpsConfigRecord {
};

struct AriaGpsDataRecord {
int64_t captureTimestampNs;
int64_t utcTimeMs;
std::string provider;
float latitude;
float longitude;
float altitude;
float accuracy;
int64_t captureTimestampNs; ///< @brief capture time in device domain
int64_t utcTimeMs; ///< @brief capture time in UTC domain
std::string provider; ///< @brief GPS provider
float latitude; ///< @brief latitude of the position in Degrees Minutes Seconds (DMS)
float longitude; ///< @brief longitude of the position in Degrees Minutes Seconds (DMS)
float altitude; ///< @brief altitude of the position
float accuracy; ///< @brief horizontal accuracy of the position in meters
float verticalAccuracy; ///< @brief vertical accuracy of the position in meters
float speed;
std::vector<std::string> rawData;
};
Expand Down

0 comments on commit c8c030d

Please sign in to comment.