Fix test errors and type checking errors induced by a previous PR.#194
Open
fengxizhou wants to merge 1 commit intomainfrom
Open
Fix test errors and type checking errors induced by a previous PR.#194fengxizhou wants to merge 1 commit intomainfrom
fengxizhou wants to merge 1 commit intomainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
sraikund16
reviewed
Oct 23, 2024
| f"event_args_{version.get_version_str()}.yaml", | ||
| ) | ||
| ) | ||
| pkg_path: Path = Path(__file__).parent |
Contributor
There was a problem hiding this comment.
Why do we have to get package path this way instead of using importlib.resources.files(package)?
Contributor
Author
There was a problem hiding this comment.
Both should work, but HTA has been using the same method from the start.
sraikund16
approved these changes
Oct 23, 2024
Contributor
|
@fengxizhou has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
) Summary: ## What does this PR do? Fixes # 193 - Wrong Configuration Path Caused Test Failures This PR fixes four things in a previous diff. (1) A wrong file path for event_args_formats caused test errors. The fix is to update to the correct path. (2) A type checking error caused by Library stubs not installed for "yaml". The fix is to add the following lines into `pyproject.toml` file. ``` [[tool.mypy.overrides]] module = "yaml" ignore_missing_imports = true ``` (3) Update mypy setting in .pre-commit-config.yaml to workaround errors: "Source file found twice under different module names" (4) Fix format warnings when importing sorces fbcode into github. ## Before submitting - [ x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) - [ ] N/A - [ ] Did you write any new necessary tests? - [x ] N/A - [ ] Did you make sure to update the docs? - [x ] N/A - [x] Did you update the [changelog](https://github.com/facebookresearch/HolisticTraceAnalysis/blob/main/CHANGELOG.md)? - [ ] N/A Reviewed By: briancoutinho, sraikund16 Differential Revision: D64839500 Pulled By: fengxizhou
facebook-github-bot
force-pushed
the
wrong-parse_event_args_yaml-path
branch
from
db04f8d to
39c169b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64839500 |
) Summary: ## What does this PR do? Fixes # 193 - Wrong Configuration Path Caused Test Failures This PR fixes four things in a previous diff. (1) A wrong file path for event_args_formats caused test errors. The fix is to update to the correct path. (2) A type checking error caused by Library stubs not installed for "yaml". The fix is to add the following lines into `pyproject.toml` file. ``` [[tool.mypy.overrides]] module = "yaml" ignore_missing_imports = true ``` (3) Update mypy setting in .pre-commit-config.yaml to workaround errors: "Source file found twice under different module names" (4) Fix format warnings when importing sorces fbcode into github. ## Before submitting - [ x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) - [ ] N/A - [ ] Did you write any new necessary tests? - [x ] N/A - [ ] Did you make sure to update the docs? - [x ] N/A - [x] Did you update the [changelog](https://github.com/facebookresearch/HolisticTraceAnalysis/blob/main/CHANGELOG.md)? - [ ] N/A Reviewed By: briancoutinho, sraikund16 Differential Revision: D64839500 Pulled By: fengxizhou
facebook-github-bot
force-pushed
the
wrong-parse_event_args_yaml-path
branch
from
39c169b to
0921d22
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64839500 |
niufei8888
pushed a commit
to niufei8888/HolisticTraceAnalysis
that referenced
this pull request
Oct 24, 2024
…acebookresearch#194) Summary: ## What does this PR do? Fixes # 193 - Wrong Configuration Path Caused Test Failures This PR fixes four things in a previous diff. (1) A wrong file path for event_args_formats caused test errors. The fix is to update to the correct path. (2) A type checking error caused by Library stubs not installed for "yaml". The fix is to add the following lines into `pyproject.toml` file. ``` [[tool.mypy.overrides]] module = "yaml" ignore_missing_imports = true ``` (3) Update mypy setting in .pre-commit-config.yaml to workaround errors: "Source file found twice under different module names" (4) Fix format warnings when importing sorces fbcode into github. ## Before submitting - [ x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) - [ ] N/A - [ ] Did you write any new necessary tests? - [x ] N/A - [ ] Did you make sure to update the docs? - [x ] N/A - [x] Did you update the [changelog](https://github.com/facebookresearch/HolisticTraceAnalysis/blob/main/CHANGELOG.md)? - [ ] N/A Pull Request resolved: facebookresearch#194 Differential Revision: D64839500 Privacy Context Container: L1200110 Reviewed By: briancoutinho, sraikund16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # 193 - Wrong Configuration Path Caused Test Failures
This PR fixes four things in a previous diff.
(1) A wrong file path for event_args_formats caused test errors. The fix is to update to the correct path.
(2) A type checking error caused by Library stubs not installed for "yaml". The fix is to add the following lines into
pyproject.tomlfile.(3) Update mypy setting in .pre-commit-config.yaml to workaround errors: "Source file found twice under different module names"
(4) Fix format warnings when importing sorces fbcode into github.
Before submitting