Upgrade to python 3.12 in pre-commit test.#275
Closed
DaylonSrinivasan wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Upgrade to python 3.12 in pre-commit test.#275DaylonSrinivasan wants to merge 1 commit intofacebookresearch:mainfrom
DaylonSrinivasan wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78677575 |
DaylonSrinivasan
pushed a commit
to DaylonSrinivasan/HolisticTraceAnalysis
that referenced
this pull request
Jul 21, 2025
Summary:
Pre-commit is currently running python version 3.0, which doesn't include some of the latest python syntax.
Currently failing with:
```
hta/common/call_stack.py:504: error: X | Y syntax for unions requires Python
3.10 [syntax]
remapped_tids: Dict[int, Dict[int, int]] | None = None,
```
Differential Revision: D78677575
DaylonSrinivasan
force-pushed
the
export-D78677575
branch
from
57f3b0a to
068e4e1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78677575 |
DaylonSrinivasan
pushed a commit
to DaylonSrinivasan/HolisticTraceAnalysis
that referenced
this pull request
Jul 21, 2025
Summary:
Pre-commit is currently running python version 3.0, which doesn't include some of the latest python syntax.
Currently failing with:
```
hta/common/call_stack.py:504: error: X | Y syntax for unions requires Python
3.10 [syntax]
remapped_tids: Dict[int, Dict[int, int]] | None = None,
```
Differential Revision: D78677575
DaylonSrinivasan
force-pushed
the
export-D78677575
branch
from
068e4e1 to
1b77bc0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78677575 |
DaylonSrinivasan
force-pushed
the
export-D78677575
branch
2 times, most recently
from
7850357 to
7ccf27a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78677575 |
DaylonSrinivasan
pushed a commit
to DaylonSrinivasan/HolisticTraceAnalysis
that referenced
this pull request
Jul 21, 2025
Summary:
Pre-commit is currently running python version 3.0, which doesn't include some of the latest python syntax.
Currently failing with:
```
hta/common/call_stack.py:504: error: X | Y syntax for unions requires Python
3.10 [syntax]
remapped_tids: Dict[int, Dict[int, int]] | None = None,
```
The comment previously suggested to keep the python versions consistent with .circleci/config.yml. But this file was deleted in facebookresearch#211 and replaced with https://github.com/facebookresearch/HolisticTraceAnalysis/blob/main/.github/workflows/ci.yml, which uses version 3.10 and 3.12.
Differential Revision: D78677575
DaylonSrinivasan
force-pushed
the
export-D78677575
branch
from
7ccf27a to
24892d0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78677575 |
DaylonSrinivasan
force-pushed
the
export-D78677575
branch
from
24892d0 to
52481bf
Compare
DaylonSrinivasan
pushed a commit
to DaylonSrinivasan/HolisticTraceAnalysis
that referenced
this pull request
Jul 21, 2025
Summary: Pull Request resolved: facebookresearch#275 Pre-commit is currently running python version 3.0, which doesn't include some of the latest python syntax. Currently failing with: ``` hta/common/call_stack.py:504: error: X | Y syntax for unions requires Python 3.10 [syntax] remapped_tids: Dict[int, Dict[int, int]] | None = None, ``` The comment previously suggested to keep the python versions consistent with .circleci/config.yml. But this file was deleted in facebookresearch#211 and replaced with https://github.com/facebookresearch/HolisticTraceAnalysis/blob/main/.github/workflows/ci.yml, which uses version 3.10 and 3.12. Differential Revision: D78677575
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78677575 |
DaylonSrinivasan
force-pushed
the
export-D78677575
branch
from
52481bf to
ab8863c
Compare
Summary:
Pre-commit is currently running python version 3.0, which doesn't include some of the latest python syntax.
Currently failing with:
```
hta/common/call_stack.py:504: error: X | Y syntax for unions requires Python
3.10 [syntax]
remapped_tids: Dict[int, Dict[int, int]] | None = None,
```
The comment previously suggested to keep the python versions consistent with .circleci/config.yml. But this file was deleted in facebookresearch#211 and replaced with .github/workflows/ci.yml, which uses version 3.10 and 3.12.
Differential Revision: D78677575
DaylonSrinivasan
force-pushed
the
export-D78677575
branch
from
ab8863c to
0118ebc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78677575 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pre-commit is currently running python version 3.0, which doesn't include some of the latest python syntax.
Currently failing with:
Differential Revision: D78677575