Back out "Revert pull/274" with bug fix#289
Closed
hjli-creator wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Back out "Revert pull/274" with bug fix#289hjli-creator wants to merge 1 commit intofacebookresearch:mainfrom
hjli-creator wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79219118 |
hjli-creator
added a commit
to hjli-creator/HolisticTraceAnalysis
that referenced
this pull request
Jul 30, 2025
Summary: Additional details in test plan. Differential Revision: D79219118
hjli-creator
force-pushed
the
export-D79219118
branch
from
52bab5a to
23d78f1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79219118 |
Summary: Additional details in test plan. Differential Revision: D79219118
hjli-creator
force-pushed
the
export-D79219118
branch
from
23d78f1 to
b0b2e88
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79219118 |
Contributor
|
This pull request has been merged in 28f8f44. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
The original diff D78594843 had some issue and brought down offline trace analysis runner S545236,
it was reverted in D79185506.
Now we have identified the root cause and found the solution, this commit revived the original diff with bug fix.
Fix:
Original diff failed to initialize FaaS job because it failed to get argument "index::python_id". The reason is likely because the FaaS environment didn't find config file event_args_1.0.0.yaml so it loaded the default arg values in default_event_args.py, which was missing to add new arg "index::python_id".
The fix is 1. in
ARGS_INDEX_FUNCin event_args_yaml_parser.py if an argument key is missing in the available args, then skip fetching it. 2. update default_event_args.py to add the new args.Differential Revision: D79219118