Return False instead of raising an error if graph validation fails.#292
Closed
DaylonSrinivasan wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Return False instead of raising an error if graph validation fails.#292DaylonSrinivasan wants to merge 1 commit intofacebookresearch:mainfrom
DaylonSrinivasan wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79759829 |
DaylonSrinivasan
force-pushed
the
export-D79759829
branch
from
7db0742 to
08e63c4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79759829 |
…acebookresearch#292) Summary: The main CriticalPathAnalysis.critical_path_analysis method has the following contract: Returns: Tuple[CPGraph, bool] a pair of CPGraph object and a success or fail boolean value. True indicates that the critical path analysis algorithm succeeded. But prior to this change, when graph validation failed, it actually raised a ValueError instead, while other errors (such at network failures) returned False. Mixed error handling (exceptions vs returning false) is an anti-pattern; this change makes it so that we consistently return False instead. Reviewed By: seansundor Differential Revision: D79759829
DaylonSrinivasan
force-pushed
the
export-D79759829
branch
from
08e63c4 to
e3fea59
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79759829 |
Contributor
|
This pull request has been merged in b75f84d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D79759829